Skip to content

Conversation

@franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jul 15, 2025

Stack:

Describe your changes

Support RPC 0.9.0-rc.1

  • Add StarknetMessageFeeEstimate
  • Add preConfirmed to StarknetTransactionFinalityStatus
  • Add candidate and preConfirmed to StarknetTransactionStatus

Linked issues

Closes

Breaking changes

  • This issue contains breaking changes

  • Change pending to preConfirmed case for StarknetBlockId

  • lengthin StarknetEdgeNode is now type to UInt

  • Gas-related variables in StarknetResources, StarknetExecutionResources and StarknetInnerCallExecutionResources are now of type UInt

  • Return type of estimateMessageFee is now StarknetMessageFeeEstimate

@franciszekjob franciszekjob mentioned this pull request Jul 15, 2025
1 task
Comment on lines -19 to -23
let maxFee: Felt

enum CodingKeys: String, CodingKey {
case accountAddress = "address"
case maxFee = "max_fee"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Not used anywhere

Comment on lines -15 to +16
static let predeployedAccount1: AccountDetails = .init(privateKey: "0x0000000000000000000000000000000069bbdd410db5a6f817e5fae1bf3191b3", publicKey: "0x00d576e1ba0ffd7963507ddfd08b5fd967046fd5eafca4a668d73c60b17ebb6d", address: "0x00a97c3906ca442b26b68f9b510ee15c4a6994764de828a1b5dc04fe7f717063", salt: 20)
static let predeployedAccount2: AccountDetails = .init(privateKey: "0x0000000000000000000000000000000088ca21b05b8765f9654c171f65b2327c", publicKey: "0x07693c6c6672c19d2d3a20dbec30758d40ac1ea3e536defedc68764ba8234ed0", address: "0x051ff12b24abce0508e5dfde92be06aade5c59fcae29dd11c6076a6cced3c434", salt: 20)
static let predeployedAccount1: AccountDetails = .init(privateKey: "0x00000000000000000000000000000000a2ed22bb0cb0b49c69f6d6a8d24bc5ea", publicKey: "0x0198e98e771ebb5da7f4f05658a80a3d6be2213dc5096d055cbbefa62901ab06", address: "0x01323cacbc02b4aaed9bb6b24d121fb712d8946376040990f2f2fa0dcf17bb5b", salt: 20)
static let predeployedAccount2: AccountDetails = .init(privateKey: "0x00000000000000000000000000000000c1c7db92d22ef773de96f8bde8e56c85", publicKey: "0x026df62f8e61920575f9c9391ed5f08397cfcfd2ade02d47781a4a8836c091fd", address: "0x034864aab9f693157f88f2213ffdaa7303a46bbea92b702416a648c3d0e42f35", salt: 20)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Changed because class hash in devnet was updated

@franciszekjob franciszekjob marked this pull request as ready for review July 15, 2025 11:56
@franciszekjob franciszekjob requested a review from cptartur July 15, 2025 13:17
Copy link
Collaborator

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 👍🏻 , just some minor comments left

@franciszekjob franciszekjob requested a review from DelevoXDG July 17, 2025 08:07
@franciszekjob franciszekjob merged commit c566f34 into main Jul 17, 2025
1 check passed
@franciszekjob franciszekjob deleted the feat/rpc-0.9.0 branch July 17, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants