Skip to content

Tip support #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 17, 2025
Merged

Tip support #237

merged 15 commits into from
Jul 17, 2025

Conversation

@franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Jul 15, 2025 •
edited
Loading

Describe your changes

Support tip functionality

  • Constructors in StarknetInvokeTransactionV3, StarknetDeployAccountTransactionV3 and StarknetOptionalInvokeParamsV3 accept now tip param

Linked issues

Closes

Breaking changes

  • This issue contains breaking changes

@franciszekjob franciszekjob changed the base branch from main to feat/rpc-0.9.0 July 15, 2025 10:03
@franciszekjob franciszekjob mentioned this pull request Jul 15, 2025
Merged
1 task
@franciszekjob franciszekjob marked this pull request as ready for review July 15, 2025 12:01
@franciszekjob franciszekjob requested a review from cptartur July 15, 2025 13:17
DelevoXDG
DelevoXDG approved these changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@DelevoXDG DelevoXDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/rpc-0.9.0 to main July 17, 2025 10:28
@franciszekjob franciszekjob merged commit 62fc773 into main Jul 17, 2025
1 check passed
@franciszekjob franciszekjob deleted the feat/tip-support branch July 17, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DelevoXDG DelevoXDG DelevoXDG approved these changes

@cptartur cptartur Awaiting requested review from cptartur

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@franciszekjob @DelevoXDG