fix: missing solana-signer extration from solana-sdk#3995
Merged
jacobcreech merged 12 commits intosolana-foundation:masterfrom Nov 20, 2025
Merged
fix: missing solana-signer extration from solana-sdk#3995jacobcreech merged 12 commits intosolana-foundation:masterfrom
jacobcreech merged 12 commits intosolana-foundation:masterfrom
Conversation
|
@pratikbuilds is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
nutafrost
moved this from Security Review Done
to Security Review Required
in Anchor 1.0
jamie-osec
requested changes
Oct 17, 2025
Collaborator
jamie-osec
left a comment
jamie-osec
left a comment
There was a problem hiding this comment.
Remaining imports:
client/src/blocking.rs:13client/src/nonblocking.rs:9
Also some docs examples which imo should be fixed for best practice:
docs/content/docs/features/declare-program.mdx:596docs/content/docs/clients/rust.mdx:176client/src/lib.rs:15
Collaborator
|
Additionally, as a drive-by fix, I would suggest making the |
added 4 commits
October 17, 2025 21:14
This reverts commit c8cf603.
Collaborator
|
@Otter-0x4ka5h Please fix the failed tests. |
nutafrost
moved this from Security Review Required
to Security Review Done
in Anchor 1.0
jacobcreech
approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from Security Review Done
to Done
in Anchor 1.0
Otter-0x4ka5h
added a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
…on#3995) * refactor: extract solana-signer from solana-sdk in anchor-client and anchor-cli * Revert "Revert "feat: tests"" This reverts commit c8cf603. * requested changes * fix: docs * fix: cargo.toml * fix: ci tests * fix: ci tests * add dependency * add dependency * add dependency * fix: remove from workspace --------- Co-authored-by: 0xPratik <sariapratik@gmail.com> Co-authored-by: Akash Thota <your.email@example.com> Co-authored-by: Akash Thota <0x4ka5h@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3884