client: Export all types used by the public API#4211
Merged
jamie-osec merged 11 commits intosolana-foundation:masterfrom Mar 2, 2026
Merged
Conversation
* Export `solana_rpc_client_api::client_error::Error as SolanaClientError` * Export `solana_rpc_client_api::config::RpcSendTransactionConfig` * Export `solana_rpc_client_api::filter::RpcFilterType`
|
@acheroncrypto is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
@acheroncrypto I think this PR solves the issue in a cleaner way than mine; can you rebase on master and see if CI passes? |
…used-by-the-public-api
Collaborator
Author
|
Failures were unrelated but updated. |
Collaborator
|
Would you mind modifying the doctest to be accurate to the new API? |
jamie-osec
reviewed
Mar 2, 2026
| @@ -9,15 +9,10 @@ | |||
| //! ```ignore | |||
Collaborator
There was a problem hiding this comment.
It would be nice to have this be no_run to avoid any more drift in docs vs real API, but that requires some awkward work (see my PR) and as long as we don't make any other breaking changes to the API it should be fine.
jamie-osec
approved these changes
Mar 2, 2026
swaroop-osec
approved these changes
Mar 2, 2026
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#4031 removed the
solana-sdkexport without adding the types that are used by the public API. This practically made the client unusable without adding additional dependencies. Users also don't get any autocomplete for the missing dependencies and need to figure them out themselves.Summary of changes
Export the following types that are used by the public API:
solana_commitment_config::CommitmentConfigsolana_instruction::Instructionsolana_program::hash::Hashsolana_pubsub_client::nonblocking::pubsub_client::PubsubClientErrorsolana_rpc_client_api::client_error::Error as SolanaClientErrorsolana_rpc_client_api::config::RpcSendTransactionConfigsolana_rpc_client_api::filter::RpcFilterTypesolana_signer::Signersolana_signer::SignerErrorsolana_transaction::TransactionRemove the redundant dependencies in
client/example