feat: (PRO-407) Use solana-signers crate instead of custom Kora Signer#231
Merged
dev-jodee merged 1 commit intorelease/feature-freeze-for-auditfrom Oct 10, 2025
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 118ee80 in 1 minute and 4 seconds. Click for details.
- Reviewed
4163lines of code in38files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. crates/lib/src/signer/pool.rs:153
- Draft comment:
It appears you are callingrand::rng()which is not available in rand 0.9. Consider usingrand::thread_rng()and then usingrng.gen_range(0..self.signers.len())instead. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. crates/lib/src/signer/pool.rs:160
- Draft comment:
Similarly, in the weighted selection implementation, replacerand::rng()andrng.random_range()withrand::thread_rng()andrng.gen_range(). - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. crates/lib/src/state.rs:22
- Draft comment:
Typo: The comment says "If client provided a signer signer_key...". Consider removing the redundant "signer" to just read "If client provided a signer_key...". - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_AJwbt9mFAA876kIh
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
amilz
reviewed
Oct 9, 2025
amilz
approved these changes
Oct 9, 2025
99af386
into
release/feature-freeze-for-audit
13 of 14 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Replace custom Kora Signer with
solana-signerscrate, updating configurations, transaction handling, and error management.KoraSignerwithsolana-signerscrate across the codebase.signer/config.rs,signer/pool.rs, andstate.rsto usesolana-signers.signer/memory_signer,signer/privy,signer/turnkey, andsigner/vault.SignerConfiginsigner/config.rsto build signers usingsolana-signers.SignerPoolConfigto validate and initialize signers with the new library.transaction/versioned_transaction.rsto usesolana-signers.VersionedTransactionResolvedand related operations.KoraErrorconversions to handlesolana-signers::SignerError.tests/common/mod.rsandtests/config_mock.rsto reflect signer changes.This description was created by
for 118ee80. You can customize this summary. It will automatically update as commits are pushed.
📊 Unit Test Coverage
Unit Test Coverage: 84.4%
View Detailed Coverage Report