Run tests on GitHub actions #136
Open
+104
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
github-actions
branch
from
a980a7e to
ecccbe3
Compare
|
Can we merge this before laying hand on this extension? I would like to bring this over and have it circleci free on the coming PR if we can. |
|
Needs solidusio/solidus_dev_support#230 for latest chrome fixes |
tvdeyen
force-pushed
the
github-actions
branch
10 times, most recently
from
b5faaa4 to
5d58703
Compare
This was referenced Apr 14, 2025
Ruby 3.4 extracted csv into a separate gem. Solidus Promotions requires CSV but does not depend on it yet.
Rails 7.0 has several issues with Ruby >= 3.1 and is EOL of live since 2025-04-01
Is is common to run `bin/rspec` instead of `bundle exec rspec`.
And test Rails 8 with soliuds 4.5
Chrome causes headaches
|
Needs solidusio/solidus#6231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the https://github.com/solidusio/test-solidus-extension action to run tests on GitHub rather than CircleCI
Note: this also drops support for Rails 7.0 as it has several issues with Ruby >= 3.1 and is EOL since 2025-04-01