Pin headless chrome to 133 #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
bot
added
the
needs changelog label
tvdeyen
added
bug
|
Testing with solidusio-contrib/solidus_social#136 |
Unless the capybara team figured out how to solve this bug: teamcapybara/capybara#2800 Also setting some flags we need for Chrome 133 support. And completely register a new driver. Do not try to inherit from the selenium web driver. It does not contain all the args we need.
We need to tell the Selenium Browser Manager to download that version
Found in ref: teamcapybara/capybara#2796
Hopefully it will be less flaky
jarednorman
approved these changes
Apr 11, 2025
|
Nooo. What? Why has this been merged? |
|
Dang. Should I have kept it as draft? Meh. |
This was referenced Apr 14, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the capybara team figured out how to solve this bug:
teamcapybara/capybara#2800
Also setting some flags we need for Chrome 133 support.