Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/apis page full reload #109

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

Charlesthebird
Copy link
Collaborator

@Charlesthebird Charlesthebird commented Nov 7, 2024

Problem is that we need a full page reload to access the apis page in order for auth to be applied.
This isn't a great solution though, because the entire page refreshes and it doesn't look very seamless. Need a better UX but to still get the auth applied. Maybe this could be solved by a new environment variable (VITE_FULL_LOAD_PAGES).

Edit: this is now updated with the environment variable.

Charlesthebird and others added 3 commits November 7, 2024 14:55
@jmhbh jmhbh marked this pull request as ready for review November 8, 2024 05:35
@jmhbh
Copy link
Contributor

jmhbh commented Nov 8, 2024

/skip-changelog

@Charlesthebird
Copy link
Collaborator Author

/skip-changelog

@Charlesthebird Charlesthebird changed the title DONT MERGE: /apis page full reload /apis page full reload Nov 8, 2024
@Charlesthebird Charlesthebird merged commit f41d72c into main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants