Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/apis page full reload #109

Merged
merged 4 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ ENV VITE_PORTAL_SERVER_URL=$VITE_PORTAL_SERVER_URL \
VITE_HOME_IMAGE_URL=$VITE_HOME_IMAGE_URL \
VITE_APIS_IMAGE_URL=$VITE_APIS_IMAGE_URL \
VITE_LOGO_IMAGE_URL=$VITE_LOGO_IMAGE_URL \
VITE_COMPANY_NAME=$VITE_COMPANY_NAME
VITE_COMPANY_NAME=$VITE_COMPANY_NAME \
VITE_API_PAGE_RELOAD=$VITE_API_PAGE_RELOAD

# Copy the server files, (this includes the UI build).
WORKDIR /app
Expand All @@ -70,4 +71,5 @@ ENTRYPOINT VITE_PORTAL_SERVER_URL=$VITE_PORTAL_SERVER_URL \
VITE_APIS_IMAGE_URL=$VITE_APIS_IMAGE_URL \
VITE_LOGO_IMAGE_URL=$VITE_LOGO_IMAGE_URL \
VITE_COMPANY_NAME=$VITE_COMPANY_NAME \
VITE_API_PAGE_RELOAD=$VITE_API_PAGE_RELOAD \
node ./bin/www
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ ifneq ($(VITE_COMPANY_NAME),)
else ifneq ($(COMPANY_NAME),)
UI_ARGS += VITE_COMPANY_NAME=$(COMPANY_NAME)
endif
#
# API_PAGE_RELOAD
ifneq ($(VITE_API_PAGE_RELOAD),)
UI_ARGS += VITE_API_PAGE_RELOAD=$(VITE_API_PAGE_RELOAD)
else ifneq ($(API_PAGE_RELOAD),)
UI_ARGS += VITE_API_PAGE_RELOAD=$(API_PAGE_RELOAD)
endif



Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ You can add these environment variables to a `.env.local` file in the `projects/
- `VITE_HOME_IMAGE_URL` - This is an optional parameter to set the image URL on the home page.
- `VITE_APIS_IMAGE_URL` - This is an optional parameter to set the image URL on the apis page.
- `VITE_LOGO_IMAGE_URL` - This is an optional parameter to set the image URL for the logo in the upper left.
- `VITE_API_PAGE_RELOAD` - This is an optional parameter that ensures the API page reloads when navigating to it. This is useful when gating the API page behind an auth flow.

#### Environment Variables for PKCE Authorization Flow

Expand Down
5 changes: 5 additions & 0 deletions changelog/v0.0.36/api-page-reload-env-var.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
changelog:
- type: NEW_FEATURE
description: >-
Adds a new env var for ensuring the API page reloads when navigating to it. This is necessary when using
auth with the portal frontend for gloo v1.17.x installations.
4 changes: 3 additions & 1 deletion projects/ui/src/Components/Structure/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Link, NavLink, useLocation } from "react-router-dom";
import { ReactComponent as Logo } from "../../Assets/logo.svg";
import { AppContext } from "../../Context/AppContext";
import { AuthContext } from "../../Context/AuthContext";
import { logoImageURL } from "../../user_variables.tmplr";
import {apiPageReload, logoImageURL} from "../../user_variables.tmplr";
import { ErrorBoundary } from "../Common/ErrorBoundary";
import { HeaderStyles } from "./Header.style";
import HeaderSectionLoggedIn from "./HeaderSectionLoggedIn";
Expand Down Expand Up @@ -89,6 +89,8 @@ export function Header() {
*/}
<NavLink
to={"/apis"}
// if apiPageReload is true use the onclick to reload the page
onClick={apiPageReload === "true" ? () => (window.location.href = "/apis") : undefined}
className={`navLink ${inAPIsArea ? "active" : ""}`}
>
APIs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { AppContext } from "../../../Context/AppContext";
import { ErrorBoundary } from "../../Common/ErrorBoundary";
import { HeaderStyles } from "../Header.style";
import { OidcAuthCodeHeaderDropdown } from "./OidcAuthCodeHeaderDropdown";
import {apiPageReload} from "../../../user_variables.tmplr";

/**
* This is for when there is an
Expand Down Expand Up @@ -36,6 +37,7 @@ const OidcAuthCodeHeaderVariant = () => {
</NavLink>
<NavLink
to={"/apis"}
onClick={apiPageReload === "true" ? () => (window.location.href = "/apis") : undefined}
className={`navLink ${inAPIsArea ? "active" : ""}`}
>
APIs
Expand Down
8 changes: 8 additions & 0 deletions projects/ui/src/user_variables.tmplr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,11 @@ export const logoImageURL = templateString(
import.meta.env.VITE_LOGO_IMAGE_URL,
""
);

export const apiPageReload = templateString(
"{{ tmplr.apiPageReload }}",
insertedEnvironmentVariables?.VITE_API_PAGE_RELOAD,
import.meta.env.VITE_API_PAGE_RELOAD,
"false"
);

Loading