Open
Conversation
dalonsod
reviewed
Nov 8, 2023
dalonsod
reviewed
Nov 10, 2023
| <field name="inherit_id" ref="helpdesk_mgmt.helpdesk_ticket_view_search"/> | ||
| <field name="arch" type="xml"> | ||
| <search> | ||
| <field name="name" string="Name Equipment" filter_domain="[('equipment_ids.name', 'ilike', self)]"/> |
Contributor
There was a problem hiding this comment.
Please also add groups management to search field
dalonsod
reviewed
Nov 10, 2023
Comment on lines
+13
to
+15
| <button class="oe_stat_button" type="object" name="action_view_tickets_equipment" string="Tickets" icon="fa-life-ring"> | ||
| <field name="num_tickets" string="Tickets" widget="statinfo" groups="helpdesk_mgmt.group_helpdesk_user"/> | ||
| </button> |
Contributor
There was a problem hiding this comment.
Please move groups management to whole button.
dalonsod
reviewed
Nov 10, 2023
|
|
||
| allow_ticket = fields.Boolean(string="Allow Tickets", default=False) | ||
|
|
||
| num_tickets = fields.Integer(string="Tickets", compute="_compute_num_tickets", store=True) |
Contributor
There was a problem hiding this comment.
Please rename field to a more Odoo standard conventions one:
Suggested change
| num_tickets = fields.Integer(string="Tickets", compute="_compute_num_tickets", store=True) | |
| ticket_count = fields.Integer(string="Ticket count", compute="_compute_ticket_count", store=True) |
dalonsod
reviewed
Nov 10, 2023
| class MaintenanceEquipment(models.Model): | ||
| _inherit = "maintenance.equipment" | ||
|
|
||
| ticket_ids = fields.Many2many('helpdesk.ticket', string = "Tickets") |
Contributor
There was a problem hiding this comment.
python attributes should be defined without spaces:
Suggested change
| ticket_ids = fields.Many2many('helpdesk.ticket', string = "Tickets") | |
| ticket_ids = fields.Many2many('helpdesk.ticket', string="Tickets") |
dalonsod
reviewed
Nov 10, 2023
| <field name="inherit_id" ref="maintenance.hr_equipment_view_kanban" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//t[@t-name='kanban-box']//field[@name='activity_ids']" position="before"> | ||
| <field name="num_tickets" string=" Tickets" widget="statinfo" groups="helpdesk_mgmt.group_helpdesk_user"/> |
Contributor
There was a problem hiding this comment.
Typo in label:
Suggested change
| <field name="num_tickets" string=" Tickets" widget="statinfo" groups="helpdesk_mgmt.group_helpdesk_user"/> | |
| <field name="num_tickets" string="Tickets" widget="statinfo" groups="helpdesk_mgmt.group_helpdesk_user"/> |
dalonsod
reviewed
Nov 10, 2023
| <field name="inherit_id" ref="helpdesk_mgmt.ticket_view_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='number']" position="after"> | ||
| <field name="has_equipment" groups="base_maintenance_group.group_maintenance_user"/> |
Contributor
There was a problem hiding this comment.
Please set hidden by default:
Suggested change
| <field name="has_equipment" groups="base_maintenance_group.group_maintenance_user"/> | |
| <field name="has_equipment" groups="base_maintenance_group.group_maintenance_user" optional="hide"/> |
dalonsod
reviewed
Nov 10, 2023
| <field name="inherit_id" ref="maintenance.hr_equipment_view_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr="//field[@name='name']" position="after"> | ||
| <field name="num_tickets" string="Tickets" groups="helpdesk_mgmt.group_helpdesk_user"/> |
Contributor
There was a problem hiding this comment.
Please set optional:
Suggested change
| <field name="num_tickets" string="Tickets" groups="helpdesk_mgmt.group_helpdesk_user"/> | |
| <field name="num_tickets" string="Tickets" groups="helpdesk_mgmt.group_helpdesk_user" optional="show"/> |
|
LGTM, only see that it would be necessary to add the translations |
Anxo82
force-pushed
the
16.0-add-helpdesk_mgmt_maintenance
branch
from
462ea83 to
4da8242
Compare
dalonsod
reviewed
Nov 17, 2023
| class MaintenanceEquipment(models.Model): | ||
| _inherit = "maintenance.equipment" | ||
|
|
||
| ticket_ids = fields.Many2many('helpdesk.ticket', string="Tickets") |
Contributor
There was a problem hiding this comment.
This works fine, but we should code it in a more secure way. Please look a this example
and
, in order to explicity link ticket_ids here and equipment_ids in ticket model. This is because other addons could create some alternative Many2many relations between these two models, that can cause conflict.
Moreover, both fields should be marked as copy=False, because e.g. when a ticket and/or an equipment are duplicated, relations shouldn't be kept.
Anb ticket_ids should be readonly IMO (not tested, I don't know if it can be a source of problems).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links Odoo's
maintenancewith OCA'shelpdek_mgmt.