Issue #22407: ConfigReload fails when RADIUS options are enabled #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
force-pushed
the
anders.radius-options-fix
branch
from
4f7e975 to
41d4a63
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RADIUS statistics adds a config entry which is not valid in YANG. The option adds the True/False boolean values instead of the 'true'/'false' booleans that YANG defines, which causes failures when trying to reload/replace the config.
anders-nexthop
force-pushed
the
anders.radius-options-fix
branch
from
41d4a63 to
d69218d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Enabling RADIUS
statisticsadds config entries which are not valid in YANG. The option adds the True/False boolean values instead of the 'true'/'false' booleans that are defined in the YANG model, which causes failures when trying to reload/replace the config.How I did it
Modified relevant config command to use the correct values.
How to verify it
Manually verified.
I added a test case for
config radius statisticscommand. Note that this test follows the pattern in this file, which is not actually exercising the correct codepath (see #3754 for details).Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)