Skip to content

Issue #22407: ConfigReload fails when RADIUS options are enabled #3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue #22407: ConfigReload fails when RADIUS options are enabled #3860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/aaa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,9 @@ def statistics(option):
del_table_key('RADIUS', 'global', 'statistics')
else:
if option == 'enable':
add_table_kv('RADIUS', 'global', 'statistics', True)
add_table_kv('RADIUS', 'global', 'statistics', 'true')
elif option == 'disable':
add_table_kv('RADIUS', 'global', 'statistics', False)
add_table_kv('RADIUS', 'global', 'statistics', 'false')
radius.add_command(statistics)


Expand Down
52 changes: 52 additions & 0 deletions tests/radius_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,58 @@ def test_config_radius_authtype(self, get_cmd_module):
assert result.exit_code == 0
assert result.output == show_radius_default_output

def test_config_radius_statistics(self, get_cmd_module):
(config, show) = get_cmd_module
runner = CliRunner()
db = Db()
db.cfgdb.delete_table("RADIUS")

result = runner.invoke(config.config.commands["radius"],
["statistics", "enable"])
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert result.output == config_radius_empty_output

db.cfgdb.mod_entry("RADIUS", "global", {'statistics': 'true'})

result = runner.invoke(show.cli.commands["radius"], [], obj=db)
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert "RADIUS global statistics true" in result.output

result = runner.invoke(config.config.commands["radius"],
["statistics", "disable"])
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert result.output == config_radius_empty_output

db.cfgdb.mod_entry("RADIUS", "global", {'statistics': 'false'})

result = runner.invoke(show.cli.commands["radius"], [], obj=db)
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert "RADIUS global statistics false" in result.output

result = runner.invoke(config.config.commands["radius"],
["statistics", "default"])
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert result.output == config_radius_empty_output

db.cfgdb.mod_entry("RADIUS", "global", {'statistics': 'default'})

result = runner.invoke(show.cli.commands["radius"], [], obj=db)
print(result.exit_code)
print(result.output)
assert result.exit_code == 0
assert "RADIUS global statistics true" not in result.output
assert "RADIUS global statistics false" not in result.output

@patch("validated_config_db_connector.device_info.is_yang_config_validation_enabled", mock.Mock(return_value=True))
@patch("config.validated_config_db_connector.ValidatedConfigDBConnector.validated_set_entry", mock.Mock(side_effect=ValueError))
def test_config_radius_server_invalidkey_yang_validation(self):
Expand Down
Loading