[Fix] #534 - 3.0.0 배포 버전에서의 사소한 버그들 수정 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yungu0010
approved these changes
Apr 3, 2025
Comment on lines
+148
to
+156
| /// dimming 뒷배경을 눌렀을 때, dismiss 이벤트를 전달합니다. | ||
| override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) { | ||
| guard let touch = touches.first else { return } | ||
| let location = touch.location(in: self.view) | ||
| // toolTipView 프레임의 밖일 경우에만 dismiss | ||
| if !toolTipView.frame.contains(location) { | ||
| self.dimmingBackgroundTap.send() | ||
| } | ||
| super.touchesBegan(touches, with: event) |
There was a problem hiding this comment.
우와아ㅏㅇ 감사합니다 너무 좋네요👍👍 이 기능은 명세서에 없어서 따로 구현하지 않았는데, 안드로이드 측에 여쭤보고 맞춰가면 더 좋을 것 같습니다 !!
Comment on lines
+117
to
+121
| private func setDelegate() { | ||
| self.webView.scrollView.delegate = self | ||
| self.webView.navigationDelegate = self | ||
| self.webView.uiDelegate = self | ||
| } |
Comment on lines
-15
to
-17
| public let title: String | ||
| public let content: String | ||
| public let sendAt: String |
|
영차 영차 ~ 영치기 영 차~ 파이팅입니다~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
3.0.0 배포 버전에서의 사소한 버그들을 수정했습니다.
🌱 작업한 브랜치
🌱 PR Point
[솝트로그 UI]
[홈화면 UI]
htmlToString한 값을 이후lineSpacing을 세팅하면서 덮어씌워버리며 생긴 문제였어요. 그래서 UILabel에attributedText가 적용되어 있을 경우, 해당attributedText를 불러와lineSpacing속성을 추가할 수 있도록 함수를 수정했어요.[스와이프 시 뒤로 가기]
[푸시알림 터치 시 딥링크 화면 전환 안 됨]
NotificationPayload에 프로퍼티를 추가하면서, 객체가 정상적으로 생성되지 않아 생긴 문제였습니다. 문제되는 부분들 (해당 기능 구현을 위한 피처가 종료되었다고 전해들어) 삭제했습니다.📌 참고 사항
3.0.1로 업데이트할게요!
📸 스크린샷
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-04-03.at.20.51.16.mp4
📮 관련 이슈