-
Notifications
You must be signed in to change notification settings - Fork 16
[Fix] #534 - 3.0.0 배포 버전에서의 사소한 버그들 수정 #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d33169a
[Fix] #534 - 필요없는 주석 삭제
dlwogus0128 7a649a4
[Fix] #534 - 솝트로그 툴팁 인포 line spacing 수정
dlwogus0128 e80f359
[Fix] #534 - 솝트로그 뒷배경 눌렀을 때 dismiss
dlwogus0128 4dd2a98
[Fix] #534 - 솝트로그 툴팁 간격 수정
dlwogus0128 3682a93
[Fix] #534 - 스와이프로 뒤로 가기
dlwogus0128 9fb677a
[Fix] #534 - 홈화면 플그 로고 이미지 수정
dlwogus0128 f11c473
[Fix] #534 - 홈화면 html 스타일 덮어쓰기 수정
dlwogus0128 a1a7dbd
[Fix] #534 - 홈화면 프로젝트 로고: 활동/비활동 상태일 때만 로고 변경
dlwogus0128 d3c1f3d
[Fix] #534 - 푸시알림 터치 시 딥링크 이동 안되는 문제
dlwogus0128 2fe3180
Merge branch 'develop' of github.com:sopt-makers/SOPT-iOS into fix/#5…
dlwogus0128 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,8 @@ final class SoptlogToolTipVC: UIViewController, SoptlogToolTipViewControllable { | |
public var viewModel: SoptlogToolTipViewModel | ||
private let cancelBag = CancelBag() | ||
private let toolTipFrame: CGRect | ||
|
||
private var dimmingBackgroundTap = PassthroughSubject<Void, Never>() | ||
|
||
// MARK: - UI Components | ||
|
||
|
@@ -55,6 +57,7 @@ final class SoptlogToolTipVC: UIViewController, SoptlogToolTipViewControllable { | |
$0.text = I18N.Soptlog.toolTip | ||
$0.font = DSKitFontFamily.Suit.medium.font(size: 13) | ||
$0.numberOfLines = 0 | ||
$0.setLineSpacing(lineSpacing: 4) | ||
} | ||
|
||
init(viewModel: SoptlogToolTipViewModel, toolTipFrame: CGRect) { | ||
|
@@ -75,6 +78,8 @@ final class SoptlogToolTipVC: UIViewController, SoptlogToolTipViewControllable { | |
} | ||
} | ||
|
||
// MARK: - UI & Layout | ||
|
||
extension SoptlogToolTipVC { | ||
private func setUI() { | ||
self.view.backgroundColor = DSKitAsset.Colors.black100.color.withAlphaComponent(0.6) | ||
|
@@ -124,12 +129,30 @@ extension SoptlogToolTipVC { | |
} | ||
} | ||
|
||
// MARK: - Methods | ||
|
||
extension SoptlogToolTipVC { | ||
private func bindViewModels() { | ||
let input = SoptlogToolTipViewModel.Input( | ||
dismissbuttonTap: self.dismissButton.publisher(for: .touchUpInside).mapVoid().asDriver() | ||
dismissbuttonTap: self.dismissButton.publisher(for: .touchUpInside).mapVoid().asDriver(), | ||
dimmingBackgroundTap: self.dimmingBackgroundTap.asDriver() | ||
) | ||
|
||
_ = viewModel.transform(from: input, cancelBag: cancelBag) | ||
} | ||
} | ||
|
||
// MARK: - Override Methods | ||
|
||
extension SoptlogToolTipVC { | ||
/// dimming 뒷배경을 눌렀을 때, dismiss 이벤트를 전달합니다. | ||
override func touchesBegan(_ touches: Set<UITouch>, with event: UIEvent?) { | ||
guard let touch = touches.first else { return } | ||
let location = touch.location(in: self.view) | ||
// toolTipView 프레임의 밖일 경우에만 dismiss | ||
if !toolTipView.frame.contains(location) { | ||
self.dimmingBackgroundTap.send() | ||
} | ||
super.touchesBegan(touches, with: event) | ||
Comment on lines
+148
to
+156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 우와아ㅏㅇ 감사합니다 너무 좋네요👍👍 이 기능은 명세서에 없어서 따로 구현하지 않았는데, 안드로이드 측에 여쭤보고 맞춰가면 더 좋을 것 같습니다 !! |
||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,13 +64,16 @@ public final class SOPTWebView: UIViewController, SOPTWebViewControllable { | |
|
||
self.view.backgroundColor = DSKitAsset.Colors.black100.color | ||
|
||
self.webView.scrollView.delegate = self | ||
self.webView.navigationDelegate = self | ||
self.webView.uiDelegate = self | ||
downloadManager.webVC = self | ||
self.initializeViews() | ||
self.setupConstraints() | ||
self.setupNavigationButtonActions() | ||
self.setDelegate() | ||
} | ||
|
||
public override func viewWillAppear(_ animated: Bool) { | ||
super.viewWillAppear(animated) | ||
self.setGestureDelegate() | ||
} | ||
} | ||
|
||
|
@@ -110,6 +113,12 @@ extension SOPTWebView { | |
self?.navigationController?.popViewController(animated: true) | ||
}.store(in: self.cancelbag) | ||
} | ||
|
||
private func setDelegate() { | ||
self.webView.scrollView.delegate = self | ||
self.webView.navigationDelegate = self | ||
self.webView.uiDelegate = self | ||
} | ||
Comment on lines
+117
to
+121
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 함수 분리 너무 좋네요🚀🚀 |
||
} | ||
|
||
extension SOPTWebView: WKNavigationDelegate { | ||
|
@@ -165,3 +174,15 @@ extension SOPTWebView: WKDownloadDelegate { | |
download.delegate = self | ||
} | ||
} | ||
|
||
// MARK: - UIGestureRecognizerDelegate | ||
|
||
extension SOPTWebView: UIGestureRecognizerDelegate { | ||
private func setGestureDelegate() { | ||
self.navigationController?.interactivePopGestureRecognizer?.delegate = self | ||
} | ||
|
||
public func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool { | ||
return true | ||
} | ||
} |
12 changes: 12 additions & 0 deletions
12
...DSKit/Resources/Assets.xcassets/Home/Image/img_active_project_logo.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "Frame 1171275665.svg", | ||
"idiom" : "universal" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
...ssets.xcassets/Home/Image/img_active_project_logo.imageset/Frame 1171275665.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion
2
...les/DSKit/Resources/Assets.xcassets/Home/Image/img_playground_logo.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "Layer_1.svg", | ||
"filename" : "Frame 1171275665@2x.svg", | ||
"idiom" : "universal" | ||
} | ||
], | ||
|
4 changes: 4 additions & 0 deletions
4
...Assets.xcassets/Home/Image/img_playground_logo.imageset/Frame [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깜짝이슈ㅎㅎ,,👀