-
Notifications
You must be signed in to change notification settings - Fork 16
[Fix] #545 - 솝탬프 다크모드 대응 QA 반영 #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
배포 때문에 먼저 머지하겠습니다! 이후에 리뷰 달아주시면 반영할게요 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼼꼼한 QA 대응 고생하셨습니다~!!
@@ -170,7 +170,7 @@ extension MissionDateView { | |||
} | |||
|
|||
private func getInitializedToolBar() -> UIToolbar { | |||
let toolBar = UIToolbar(frame: CGRect(x: 0, y: 0, width: self.frame.width, height: Metric.toolBarHeight)) | |||
let toolBar = UIToolbar(frame: CGRect(x: 0, y: 0, width: Int(self.frame.width), height: Metric.toolBarHeight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Int로 타입 변경을 하신 이유가 궁금해요
} | ||
|
||
/// 행간 조정 메서드: 기존 attributedText에 속성 추가 | ||
func modifyLineSpacing(lineSpacing: CGFloat) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비회원 뷰 원인이 이거 때문이었군요!!ㅎ.ㅎ
🌴 PR 요약
솝탬프 다크모드 대응에 대한 QA를 반영했습니다.
🌱 작업한 브랜치
🌱 PR Point
QA 받았던 부분들에 대해 수정사항을 반영했습니다.
SetLineSpacing
함수의 기존 로직이 잘못 짜여 있어서 였습니다.📌 참고 사항
📸 스크린샷
📮 관련 이슈