-
Notifications
You must be signed in to change notification settings - Fork 16
[Fix] #545 - 솝탬프 다크모드 대응 QA 반영 #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2c60ad4
[Fix] #545 - MissionDate 색상 수정
dlwogus0128 708dca2
[Fix] #545 - 미션 디테일뷰 inset 수정
dlwogus0128 09a5ec5
[Fix] #545 - 누락된 dim 추가
dlwogus0128 1c9d8b2
[Fix] #545 - 솝탬프 리스트 line break
dlwogus0128 cbec6d2
[Fix] #545 - 솝탬프 이미지 업로드 시 로딩 추가
dlwogus0128 644b011
[Fix] #545 - 솝탬프 디테일뷰 미션 line break
dlwogus0128 5899c69
[Fix] #545 - Line spacing 함수 분리
dlwogus0128 4deafeb
[Fix] #545 - mission view lineSpacing 함수 수정
dlwogus0128 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,12 @@ import DSKit | |
|
||
public final class MissionDateView: UIView { | ||
private enum Metric { | ||
static let contentTop = 9.f | ||
static let contentLeadingTrailing = 14.f | ||
static let contentBottom = 10.f | ||
static let contentTop = 9 | ||
static let contentLeadingTrailing = 14 | ||
static let contentBottom = 10 | ||
|
||
static let toolBarHeight = 44.f | ||
static let chevronLength = 20.f | ||
static let toolBarHeight = 44 | ||
static let chevronLength = 20 | ||
} | ||
|
||
private enum Constant { | ||
|
@@ -28,12 +28,12 @@ public final class MissionDateView: UIView { | |
|
||
private lazy var contentStackView = UIStackView().then { | ||
$0.axis = .horizontal | ||
$0.spacing = 0.f | ||
$0.spacing = 0 | ||
} | ||
|
||
private lazy var textField = UITextField().then { | ||
$0.attributedPlaceholder = self.getAttributedString(I18N.ListDetail.missionDatePlaceHolder) | ||
$0.textColor = DSKitAsset.Colors.gray50.color | ||
$0.textColor = DSKitAsset.Colors.gray300.color | ||
$0.font = .SoptampFont.caption1 | ||
} | ||
private let rightChevron = UIImageView().then { | ||
|
@@ -121,7 +121,7 @@ extension MissionDateView { | |
private extension MissionDateView { | ||
func getAttributedString(_ text: String) -> NSAttributedString { | ||
let attributes: [NSAttributedString.Key: Any] = [ | ||
.foregroundColor: DSKitAsset.Colors.soptampGray600.color | ||
.foregroundColor: DSKitAsset.Colors.gray300.color | ||
] | ||
|
||
return NSAttributedString(string: text, attributes: attributes) | ||
|
@@ -170,7 +170,7 @@ extension MissionDateView { | |
} | ||
|
||
private func getInitializedToolBar() -> UIToolbar { | ||
let toolBar = UIToolbar(frame: CGRect(x: 0, y: 0, width: self.frame.width, height: Metric.toolBarHeight)) | ||
let toolBar = UIToolbar(frame: CGRect(x: 0, y: 0, width: Int(self.frame.width), height: Metric.toolBarHeight)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Int로 타입 변경을 하신 이유가 궁금해요 |
||
let resetButton = UIBarButtonItem( | ||
title: I18N.ListDetail.datePickerCancelButtonTitle, | ||
style: .plain, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비회원 뷰 원인이 이거 때문이었군요!!ㅎ.ㅎ