Skip to content

[foremanctl|valkey] Enable plugin for containerized deployments - #4376

Merged
pmoravec merged 2 commits into
sosreport:mainfrom
archanaserver:foreman-installer-container-support
Jul 14, 2026
Merged

[foremanctl|valkey] Enable plugin for containerized deployments#4376
pmoravec merged 2 commits into
sosreport:mainfrom
archanaserver:foreman-installer-container-support

Conversation

@archanaserver

@archanaserver archanaserver commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The plugin required foremanctl package which doesn't exist in containerized mode. Add container detection to enable the plugin and collect foremanctl health diagnostics for support cases.

@archanaserver
archanaserver force-pushed the foreman-installer-container-support branch from 205d31c to 3f02c6e Compare July 1, 2026 04:33
@packit-as-a-service

packit-as-a-service Bot commented Jul 1, 2026

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/sosreport-sos-4376
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

TurboTurtle
TurboTurtle reviewed Jul 1, 2026
View reviewed changes
Comment thread sos/report/plugins/foremanctl.py Outdated
Comment thread sos/report/plugins/foremanctl.py Outdated
@TurboTurtle TurboTurtle added Status/Needs Review This issue still needs a review from project members Kind/Bug Something is not working, and this fixes the issue Kind/Collection New or updated command or file collection labels Jul 1, 2026
@archanaserver
archanaserver force-pushed the foreman-installer-container-support branch from 3f02c6e to fc2df9c Compare July 2, 2026 06:39
ShimShtein
ShimShtein reviewed Jul 2, 2026
View reviewed changes
Comment thread sos/report/plugins/foremanctl.py Outdated
@archanaserver
archanaserver requested a review from ShimShtein July 6, 2026 07:52
shubhamsg199
shubhamsg199 reviewed Jul 6, 2026
View reviewed changes
Comment thread sos/report/plugins/foremanctl.py
ShimShtein
ShimShtein reviewed Jul 6, 2026
View reviewed changes

@ShimShtein ShimShtein left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@archanaserver
archanaserver requested a review from TurboTurtle July 7, 2026 06:34
evgeni
evgeni reviewed Jul 7, 2026
View reviewed changes
Comment thread sos/report/plugins/foremanctl.py Outdated
@archanaserver
archanaserver force-pushed the foreman-installer-container-support branch from fc2df9c to 123e225 Compare July 7, 2026 06:56
@archanaserver archanaserver changed the title [foremanctl] Enable plugin for containerized deployments [foremanctl | valkey] Enable plugin for containerized deployments Jul 7, 2026
@archanaserver archanaserver changed the title [foremanctl | valkey] Enable plugin for containerized deployments [foremanctl|valkey] Enable plugin for containerized deployments Jul 7, 2026
@archanaserver

archanaserver commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@TurboTurtle, Do these changes look good now?

@archanaserver
archanaserver requested a review from ShimShtein July 8, 2026 04:56
@shubhamsg199 shubhamsg199 mentioned this pull request Jul 8, 2026
Merged
ShimShtein
ShimShtein reviewed Jul 8, 2026
View reviewed changes

@ShimShtein ShimShtein left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it, but code-wise looks OK.

shubhamsg199
shubhamsg199 reviewed Jul 8, 2026
View reviewed changes

@shubhamsg199 shubhamsg199 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK
Tested with sos-4.11.2-1.20260707085459122884.pr4376.22.g100c7184.el9.noarch

Scenarios tested:

  • The actual secrets are scrubbed as expected.
  • Verified configuration files are collected
  • Verified log files are collected
  • Verify foremanctl command outputs are collected
  • All other scenarios mentioned in the test plan

Automation -> SatelliteQE/robottelo#22099

@shubhamsg199

shubhamsg199 commented Jul 9, 2026

Copy link
Copy Markdown

@archanaserver While automating it I noticed line 'Admin credentials: admin:mypassword' in the foremanctl.log, here the password is not scrubbed. Is this something we should handle?

@archanaserver
[foremanctl] Enable plugin for containerized deployments
96cfc08 
The plugin required foremanctl package which doesn't exist in
containerized mode. Add container detection to enable the plugin
and collect foremanctl health diagnostics for support cases.

Signed-off-by: akumari <akumari@redhat.com>
@archanaserver
[valkey] Add container support for containerized deployments
a6b6e17 
Adds container support to the valkey plugin to enable it
for containerized deployments using foremanctl/quadlet.

Signed-off-by: akumari <akumari@redhat.com>
@archanaserver
archanaserver force-pushed the foreman-installer-container-support branch from 365ddc9 to a6b6e17 Compare July 10, 2026 08:35
@archanaserver

archanaserver commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@archanaserver While automating it I noticed line 'Admin credentials: admin:mypassword' in the foremanctl.log, here the password is not scrubbed. Is this something we should handle?

Yes that's a good point. Added additional pattern to handle this format

@archanaserver

archanaserver commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@TurboTurtle Do you think it is ready to be merge?

@pmoravec

pmoravec commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@archanaserver While automating it I noticed line 'Admin credentials: admin:mypassword' in the foremanctl.log, here the password is not scrubbed. Is this something we should handle?

Yes, definitely. If you spot any other secrets (passwords, auth keys,..), please ensure they are scrubbed as well. (I see the admin creds are resolved already).

@archanaserver

archanaserver commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@TurboTurtle @pmoravec hi, can we get this in merge? or do you have other suggestion on this?

@pmoravec pmoravec added the Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer label Jul 14, 2026
@pmoravec

pmoravec commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I approved the PR, let's wait for another approval from the core team (@arif-ali or @TurboTurtle ) to let us merge it.

@arif-ali arif-ali added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Jul 14, 2026
@pmoravec
pmoravec merged commit 3b6bbcb into sosreport:main Jul 14, 2026
25 checks passed
@archanaserver
archanaserver deleted the foreman-installer-container-support branch July 15, 2026 08:13
@pmoravec pmoravec mentioned this pull request Jul 17, 2026
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arif-ali arif-ali arif-ali approved these changes
@pmoravec pmoravec pmoravec approved these changes
@TurboTurtle TurboTurtle Awaiting requested review from TurboTurtle
+4 more reviewers
@evgeni evgeni evgeni left review comments
@ShimShtein ShimShtein ShimShtein left review comments
@shubhamsg199 shubhamsg199 shubhamsg199 left review comments
@jjansky1 jjansky1 jjansky1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Kind/Bug Something is not working, and this fixes the issue Kind/Collection New or updated command or file collection Reviewed/Ready for Merge Has been reviewed, ready for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@archanaserver @shubhamsg199 @pmoravec @evgeni @arif-ali @TurboTurtle @ShimShtein @jjansky1