JP-4322: Wrap average RA to 0-360#10457
Merged
Merged
Conversation
dc00a50 to
9b9360d
Compare
drlaw1558
reviewed
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10457 +/- ##
=======================================
Coverage 85.77% 85.77%
=======================================
Files 372 372
Lines 40081 40081
=======================================
Hits 34380 34380
Misses 5701 5701 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Regtests: Some of the NIRSpec IFU data sets are impacted: CRVAL1 was negative before, is positive now. There are some small differences in the output cubes, but nothing above tolerance in the spectra extracted from them. |
tapastro
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4322
Wrap mean RA values into the 0-360 degree range to make sure recorded CRVAL1 values are not negative.
Testing locally, this change seems to make a small difference to output cubes. The most significant differences are near the spatial edges of the cube, so I expect the differences are precision/threshold related.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files