Skip to content

JP-4322: Wrap average RA to 0-360#10457

Merged
melanieclarke merged 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4322
Apr 17, 2026
Merged

JP-4322: Wrap average RA to 0-360#10457
melanieclarke merged 2 commits into
spacetelescope:mainfrom
melanieclarke:jp-4322

Conversation

@melanieclarke
Copy link
Copy Markdown
Collaborator

@melanieclarke melanieclarke commented Apr 16, 2026

Resolves JP-4322

Wrap mean RA values into the 0-360 degree range to make sure recorded CRVAL1 values are not negative.

Testing locally, this change seems to make a small difference to output cubes. The most significant differences are near the spatial edges of the cube, so I expect the differences are precision/threshold related.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 13.0 milestone Apr 16, 2026
@melanieclarke melanieclarke force-pushed the jp-4322 branch 2 times, most recently from dc00a50 to 9b9360d Compare April 16, 2026 16:57
Comment thread jwst/cube_build/ifu_cube.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (6cdcc79) to head (c4cf005).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10457   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         372      372           
  Lines       40081    40081           
=======================================
  Hits        34380    34380           
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke
Copy link
Copy Markdown
Collaborator Author

Regtests:
https://github.com/spacetelescope/RegressionTests/actions/runs/24525604523

Some of the NIRSpec IFU data sets are impacted: CRVAL1 was negative before, is positive now. There are some small differences in the output cubes, but nothing above tolerance in the spectra extracted from them.

@melanieclarke melanieclarke marked this pull request as ready for review April 16, 2026 19:36
@melanieclarke melanieclarke requested a review from a team April 16, 2026 19:36
@melanieclarke melanieclarke merged commit c092c43 into spacetelescope:main Apr 17, 2026
30 checks passed
@melanieclarke melanieclarke deleted the jp-4322 branch April 17, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants