Multislit wcsinfo

[emolter]

This PR addresses some instances where wcsinfo was taken from the top-level model.meta.wcsinfo of a MultiSlitModel despite that attribute being schema-undefined. This PR makes it so the wcsinfo of individual slits is used instead.

Based on discussion in https://jira.stsci.edu/browse/JP-4100 the addition of the parent grism S_REGION is an improvement - it seems like Tyler and Jo Taylor expected it would be there.

Prerequisite for spacetelescope/stdatamodels#710 but they don't need to be merged at the same time, this PR can go in first.

Tasks

• If you have a specific reviewer in mind, tag them.
• add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

[emolter]

tests with stdatamodels main: https://github.com/spacetelescope/RegressionTests/actions/runs/24580487414
tests with stdatamodels pointed to spacetelescope/stdatamodels#710 : https://github.com/spacetelescope/RegressionTests/actions/runs/24575930853

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (f3ce1b1) to head (0e92bd4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10464   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         372      372           
  Lines       40092    40102   +10     
=======================================
+ Hits        34544    34555   +11     
+ Misses       5548     5547    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[melanieclarke]

Looks good! I agree that the minor changes to products here should all be good changes.

[emolter]

https://github.com/spacetelescope/RegressionTests/actions/runs/24726585245 clean run for okify

[tapastro]

I find this solution a bit less intuitive than assigning the S_REGION to the primary metadata - if we assign it to one slit, it should probably apply to all of the slits? I think the solution in JP-4100 was even less elegant but prompted by a need to store the metadata in spectral products.

All that said, if this approach is meant to avoid stdatamodels#712 due to complications it causes, then this works for me.

[emolter]

@tapastro yes avoiding spacetelescope/stdatamodels#712 was the intent here.

Should we open a follow-up issue to consider more possible ways of handling this?
edit: went ahead and created https://jira.stsci.edu/browse/JP-4332

[tapastro]

With the new ticket filed and this PR matching existing patterns, I'm going to approve. We can talk about modifications to this approach on that ticket.