Add wcsinfo to multislitmodel schema#712
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 90.32% 90.33%
=======================================
Files 99 99
Lines 4641 4644 +3
=======================================
+ Hits 4192 4195 +3
Misses 449 449 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
https://github.com/spacetelescope/RegressionTests/actions/runs/24156781396 There is a lot of new metadata for this change. I wonder if we are generally ok with that or not. |
8ec098f to
ad4bd1e
Compare
The NIRSpec spec2 changes look okay – the only difference is in some empty comment-style headers. But it looks like this is now writing an imaging-type FITS WCS to WFSS and NIRCam DHS exposures, which isn’t right. That will probably need explicit handling. |
melanieclarke
left a comment
There was a problem hiding this comment.
I think this set looks good, except possibly for the SYS keywords. RADESYS, VELOSYS, and SPECSYS are FITS WCS keywords. I don't think they'd do any harm on their own, but they shouldn't be needed, detached from any other WCS keywords.
|
ok, thanks. I left them in because they do exist already in the NIRSpec multislitmodel headers, so removing them would (along with the proposed model.update changes) lead to them no longer being there. I assume based on your comment we are ok with that. |
Oh, good to know, thanks. If they're there currently, let's keep them just in case. |
|
spacetelescope/jwst#10464 handles this differently, moving relevant metadata into the slits of the multislitmodel instead of updating the multislitmodel schema. |
Required to merge #710 and see discussion on that PR.
This PR adds
wcsinfoto theMultiSlitModelschema. It turns out that we requestwcsinfofromMultiSlitModelin the pipeline and it seems it should therefore be part of the expected metadata (and as such get saved with the outputs).Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change