Skip to content

Support more WCS types#346

Open
schlafly wants to merge 2 commits into
spacetelescope:mainfrom
schlafly:more-wcs-types
Open

Support more WCS types#346
schlafly wants to merge 2 commits into
spacetelescope:mainfrom
schlafly:more-wcs-types

Conversation

@schlafly
Copy link
Copy Markdown
Collaborator

@schlafly schlafly commented Apr 9, 2026

Folks doing simulations outside romanisim may want to use WCSes other than the romanisim GWCS, gwcs, or galsim.roman.WCS. This adds support for a generic FITS header.

@schlafly schlafly requested a review from a team as a code owner April 9, 2026 15:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.20%. Comparing base (d18949b) to head (8d20487).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
romanisim/wcs.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   89.63%   89.20%   -0.43%     
==========================================
  Files          17       17              
  Lines        2633     2669      +36     
==========================================
+ Hits         2360     2381      +21     
- Misses        273      288      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants