Skip to content

Support more WCS types #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schlafly wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support more WCS types #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9171edb
support more WCS types
schlafly Apr 9, 2026
8d20487
Merge branch 'main' into more-wcs-types
schlafly Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion romanisim/bandpass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def etomjysr(bandpass, sca):
Returns
-------
float
the factor F such that MJy / sr = F * DN/s
the factor F such that MJy / sr = F * e/s
"""

abflux = get_abflux(bandpass, sca) # e/s corresponding to 3631 Jy
Expand Down
10 changes: 8 additions & 2 deletions romanisim/wcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,9 +421,15 @@ def convert_wcs_to_gwcs(wcs):
"""
if isinstance(wcs, GWCS):
return wcs.wcs
elif isinstance(wcs, gwcs.WCS):
return wcs
else:
# make a gwcs WCS from a galsim.roman WCS
return wcs_from_fits_header(wcs.header.header)
if hasattr(wcs, 'header'):
# get fits header from galsim.roman WCS
header = wcs.header.header
else:
header = wcs
return wcs_from_fits_header(header)


def get_mosaic_wcs(mosaic, shape=None, xpos=None, ypos=None, coord=None):
Expand Down
Loading