Skip to content

Support update from ObjectNode#724

Merged
emolter merged 4 commits into
spacetelescope:mainfrom
emolter:issue-723
May 4, 2026
Merged

Support update from ObjectNode#724
emolter merged 4 commits into
spacetelescope:mainfrom
emolter:issue-723

Conversation

@emolter
Copy link
Copy Markdown
Contributor

@emolter emolter commented Apr 30, 2026

Closes #723

This PR allows model.update(d) to accept ObjectNode as d. See the added unit test for a realistic example of when this is helpful.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@emolter
Copy link
Copy Markdown
Contributor Author

emolter commented Apr 30, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.35%. Comparing base (e38b4eb) to head (d79fe3a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   90.35%   90.35%           
=======================================
  Files          99       99           
  Lines        4582     4583    +1     
=======================================
+ Hits         4140     4141    +1     
  Misses        442      442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter emolter requested a review from braingram April 30, 2026 17:02
@emolter emolter marked this pull request as ready for review April 30, 2026 17:02
@emolter emolter requested a review from a team as a code owner April 30, 2026 17:02
Copy link
Copy Markdown
Contributor

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@emolter emolter enabled auto-merge (squash) May 4, 2026 13:41
@emolter emolter merged commit 377640f into spacetelescope:main May 4, 2026
21 of 22 checks passed
@emolter emolter deleted the issue-723 branch May 4, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update cannot accept ObjectNode as source

3 participants