WIP JP-4242: Extend trace model to NIRSpec and MIRI slit and slitless modes#10264
Draft
melanieclarke wants to merge 23 commits into
Draft
WIP JP-4242: Extend trace model to NIRSpec and MIRI slit and slitless modes#10264melanieclarke wants to merge 23 commits into
melanieclarke wants to merge 23 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10264 +/- ##
==========================================
+ Coverage 86.38% 86.47% +0.08%
==========================================
Files 373 373
Lines 40068 40260 +192
==========================================
+ Hits 34614 34816 +202
+ Misses 5454 5444 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1c4c526 to
e07f290
Compare
1461fc3 to
d49b2b9
Compare
04b87d5 to
109ab62
Compare
a002104 to
03cb0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4242
Adds support for NIRSpec MOS, FS, and BOTS modes as well as MIRI LRS slit and slitless modes to the adaptive_trace_model step. Updates resample_spec to allow for oversampled input data.
To use resample_spec to re-downsample the oversampled input, specify the inverse of the oversample factor as the pixel_scale_ratio. For example, use
--steps.adaptive_trace_model.oversample=2with--steps.resample_spec.pixel_scale_ratio=0.5.Needs stdatamodels changes: spacetelescope/stdatamodels#697
Notes:
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files