feat: update monitoring parameters for LiteLLM and Typesense, add notification prompts by FabrizioCafolla · Pull Request #14 · sparkfabrik/terraform-google-services-monitoring

FabrizioCafolla · 2025-12-15T10:30:46Z

PR Type

Enhancement

Description

Add notification_prompts parameter to pod restart alerts for LiteLLM and Typesense
Update default duration value from 0 to 120 seconds for pod restart monitoring
Remove alignment_period parameter from Typesense configuration
Clean up inline comments in variable definitions

Diagram Walkthrough

flowchart LR
  variables["variables.tf<br/>Update defaults"] --> litellm["lite_llm.tf<br/>Add notification_prompts"]
  variables --> typesense["typesense.tf<br/>Add notification_prompts"]
  variables --> changelog["CHANGELOG.md<br/>Document changes"]
  variables --> readme["README.md<br/>Update documentation"]

File Walkthrough

Relevant files

Configuration changes

variables.tf `Update pod restart alert parameters and defaults` variables.tf Add `notification_prompts` parameter with default `["OPENED", "CLOSED"]` for both LiteLLM and Typesense pod restart alerts Change default `duration` from 0 to 120 seconds for pod restart monitoring Remove `alignment_period` parameter from Typesense `pod_restart` configuration Remove inline comments from Typesense variable definition	+5/-7

Enhancement

lite_llm.tf `Add notification prompts to LiteLLM pod restart alerts` lite_llm.tf Add `notification_prompts` field to alert strategy block using value from `pod_restart` configuration	+1/-0
typesense.tf `Add notification prompts to Typesense pod restart alerts` typesense.tf Add `notification_prompts` field to alert strategy block using value from `pod_restart` configuration	+1/-0

Documentation

CHANGELOG.md `Document version 0.9.0 release changes` CHANGELOG.md Add version 0.9.0 release entry dated 2025-12-15 Document addition of `notification_prompts` parameter Document modification of default `duration` and `alignment_period` values	+12/-0
README.md `Update input variable documentation for LiteLLM and Typesense` README.md Update LiteLLM input variable documentation to reflect new `duration` default (120) and `notification_prompts` parameter Update Typesense input variable documentation to reflect new `duration` default (120), removed `alignment_period`, and added `notification_prompts` parameter	+2/-2

sparkfabrik-ai-bot · 2025-12-15T10:32:12Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Inconsistent Configuration The `alignment_period` parameter was removed from Typesense's `pod_restart` configuration but remains in LiteLLM's configuration. This inconsistency may cause confusion and should be intentional. If both services use similar monitoring logic, they should have consistent parameter sets. pod_restart = optional(object({ threshold = optional(number, 0) duration = optional(number, 120) auto_close_seconds = optional(number, 3600) notification_prompts = optional(list(string), ["OPENED", "CLOSED"]) }), {}) Breaking Change Changing the default `duration` from 0 to 120 seconds is a breaking change that will affect existing deployments. Users who relied on the previous default (immediate alerting) will now experience a 2-minute delay before alerts trigger. This should be clearly documented in migration notes. duration = optional(number, 120)

Copilot

Pull request overview

This PR updates monitoring alert configurations for LiteLLM and Typesense services by adding notification_prompts parameters and adjusting the default duration values for pod restart alerts from 0 to 120 seconds. However, it also inadvertently removes the alignment_period field from Typesense while retaining it in LiteLLM, creating an inconsistency.

Key Changes:

Added notification_prompts parameter with default value ["OPENED", "CLOSED"] for both LiteLLM and Typesense pod restart alerts
Changed default duration from 0 to 120 seconds for pod restart monitoring in both services
Removed alignment_period from Typesense configuration (but not from LiteLLM)
Removed inline comments explaining configuration sections

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
variables.tf	Updated `typesense` and `litellm` variable definitions to add `notification_prompts` parameter and adjust `duration` default; removed `alignment_period` from Typesense
typesense.tf	Added `notification_prompts` field to alert strategy configuration
lite_llm.tf	Added `notification_prompts` field to alert strategy configuration
README.md	Updated documentation to reflect new parameters and default values
CHANGELOG.md	Documented changes in version 0.9.0 release notes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

variables.tf

CHANGELOG.md

…ification prompts

FabrizioCafolla · 2025-12-15T10:46:30Z

/improve

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

FabrizioCafolla · 2025-12-15T10:54:38Z

/improve

FabrizioCafolla · 2025-12-15T16:00:23Z

/improve

sparkfabrik-ai-bot · 2025-12-15T16:00:46Z

PR Code Suggestions ✨

Latest suggestions up to 07553ad

Category	Suggestion	Impact
General	Align default notification_prompts value The default value for `notification_prompts` is inconsistent between the variable definition (null) and the README documentation (["OPENED", "CLOSED"]). This mismatch can cause confusion and unexpected behavior. Align the default value with the documented behavior. variables.tf [127] -notification_prompts = optional(list(string), null) +notification_prompts = optional(list(string), ["OPENED", "CLOSED"]) Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies an inconsistency between the variable definition (default `null`) and the README documentation (default `["OPENED", "CLOSED"]`). This discrepancy could lead to confusion and unexpected behavior. However, the suggestion assumes the README is correct without verifying the intended behavior, and changing defaults could affect existing users.	Medium

Previous suggestions

Suggestions up to commit 64ea4f8

Category	Suggestion	Impact
General	Inconsistent alignment_period parameter handling The `alignment_period` parameter was removed from the Typesense `pod_restart` configuration but remains in the LiteLLM configuration. This inconsistency could lead to unexpected behavior or configuration drift between similar monitoring setups. Consider either removing it from LiteLLM or adding it back to Typesense with a consistent default value. variables.tf [122-127] pod_restart = optional(object({ threshold = optional(number, 0) + alignment_period = optional(number, 60) duration = optional(number, 120) auto_close_seconds = optional(number, 3600) notification_prompts = optional(list(string), ["OPENED", "CLOSED"]) }), {}) Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies an inconsistency where `alignment_period` was removed from Typesense but kept in LiteLLM's `pod_restart` configuration. This could lead to configuration drift and unexpected behavior between similar monitoring setups, making it a valid concern for consistency.	Medium

filippolmt

LGTM!

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-15T17:10:33Z

variables.tf

          threshold          = optional(number, 0)
          alignment_period   = optional(number, 60)
-          duration           = optional(number, 0)
+          duration           = optional(number, 180)


The PR title and description mention changing the default duration from 0 to 120 seconds, but the actual code changes it to 180 seconds. This inconsistency should be corrected - either update the title/description to reflect 180 seconds, or change the code to use 120 seconds as stated.

Suggested change

duration = optional(number, 180)

duration = optional(number, 120)

Copilot · 2025-12-15T17:10:34Z

variables.tf

          threshold          = optional(number, 0)
          alignment_period   = optional(number, 60)
-          duration           = optional(number, 0)
+          duration           = optional(number, 180)


The PR title and description mention changing the default duration from 0 to 120 seconds, but the actual code changes it to 180 seconds. This inconsistency should be corrected - either update the title/description to reflect 180 seconds, or change the code to use 120 seconds as stated.

Suggested change

duration = optional(number, 180)

duration = optional(number, 120)

Copilot · 2025-12-15T17:10:34Z

variables.tf

-          duration           = optional(number, 0)
+          duration           = optional(number, 180)
          auto_close_seconds = optional(number, 3600)
+          notification_prompts = optional(list(string), null)


The default value for notification_prompts in the README is documented as ["OPENED", "CLOSED"], but in the variables.tf file it's defined as null. These should be consistent. If the default should be ["OPENED", "CLOSED"], update the variable definition. If it should be null, update the README documentation.

Suggested change

notification_prompts = optional(list(string), null)

notification_prompts = optional(list(string), ["OPENED", "CLOSED"])

FabrizioCafolla requested a review from Copilot December 15, 2025 10:30

sparkfabrik-ai-bot bot added the Review effort 2/5 label Dec 15, 2025

Copilot started reviewing on behalf of FabrizioCafolla December 15, 2025 10:34 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

variables.tf Show resolved Hide resolved

variables.tf Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

feat: update monitoring parameters for LiteLLM and Typesense, add not…

c7872e1

…ification prompts

FabrizioCafolla force-pushed the feat/change-params branch from 64ea4f8 to c7872e1 Compare December 15, 2025 10:43

FabrizioCafolla requested a review from Copilot December 15, 2025 10:44

Copilot started reviewing on behalf of FabrizioCafolla December 15, 2025 10:46 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

FabrizioCafolla added 2 commits December 15, 2025 11:53

update

28ad4ac

update

b054aaf

FabrizioCafolla added 2 commits December 15, 2025 14:49

update

aebe980

update

07553ad

FabrizioCafolla requested a review from Copilot December 15, 2025 16:00

filippolmt approved these changes Dec 15, 2025

View reviewed changes

FabrizioCafolla merged commit dce5a25 into main Dec 15, 2025
1 check passed

FabrizioCafolla deleted the feat/change-params branch December 15, 2025 16:13

Copilot started reviewing on behalf of FabrizioCafolla December 15, 2025 16:39 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

	duration = optional(number, 180)
	duration = optional(number, 120)

	notification_prompts = optional(list(string), null)
	notification_prompts = optional(list(string), ["OPENED", "CLOSED"])

Conversation

FabrizioCafolla commented Dec 15, 2025 • edited by sparkfabrik-ai-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

sparkfabrik-ai-bot bot commented Dec 15, 2025

PR Reviewer Guide 🔍

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabrizioCafolla commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

FabrizioCafolla commented Dec 15, 2025

Uh oh!

FabrizioCafolla commented Dec 15, 2025

Uh oh!

sparkfabrik-ai-bot bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Code Suggestions ✨

Previous suggestions

Uh oh!

filippolmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

FabrizioCafolla commented Dec 15, 2025 •

edited by sparkfabrik-ai-bot bot

Loading

sparkfabrik-ai-bot bot commented Dec 15, 2025 •

edited

Loading