-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update monitoring parameters for LiteLLM and Typesense, add notification prompts #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -107,26 +107,24 @@ variable "typesense" { | |||||
| project_id = optional(string, null) | ||||||
| notification_enabled = optional(bool, true) | ||||||
| notification_channels = optional(list(string), []) | ||||||
| cluster_name = optional(string, null) # GKE cluster name for container checks | ||||||
| cluster_name = optional(string, null) | ||||||
|
|
||||||
| # Apps configuration - map keyed by app_name | ||||||
| apps = optional(map(object({ | ||||||
| # Uptime check configuration (optional) | ||||||
| uptime_check = optional(object({ | ||||||
| enabled = optional(bool, true) | ||||||
| host = string | ||||||
| path = optional(string, "/readyz") | ||||||
| }), null) | ||||||
|
|
||||||
| # Container check configuration for GKE (optional) | ||||||
| container_check = optional(object({ | ||||||
| enabled = optional(bool, true) | ||||||
| namespace = string | ||||||
| pod_restart = optional(object({ | ||||||
| threshold = optional(number, 0) | ||||||
| alignment_period = optional(number, 60) | ||||||
| duration = optional(number, 0) | ||||||
| duration = optional(number, 180) | ||||||
|
||||||
| duration = optional(number, 180) | |
| duration = optional(number, 120) |
Copilot
AI
Dec 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title and description mention changing the default duration from 0 to 120 seconds, but the actual code changes it to 180 seconds. This inconsistency should be corrected - either update the title/description to reflect 180 seconds, or change the code to use 120 seconds as stated.
| duration = optional(number, 180) | |
| duration = optional(number, 120) |
Copilot
AI
Dec 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for notification_prompts in the README is documented as ["OPENED", "CLOSED"], but in the variables.tf file it's defined as null. These should be consistent. If the default should be ["OPENED", "CLOSED"], update the variable definition. If it should be null, update the README documentation.
| notification_prompts = optional(list(string), null) | |
| notification_prompts = optional(list(string), ["OPENED", "CLOSED"]) |
Uh oh!
There was an error while loading. Please reload this page.