Skip to content

Fix: set Speedscale overlay sidecar injection to true#67

Closed
kenahrens wants to merge 2 commits intomasterfrom
agent/issue-66-sidecar-inject-true
Closed

Fix: set Speedscale overlay sidecar injection to true#67
kenahrens wants to merge 2 commits intomasterfrom
agent/issue-66-sidecar-inject-true

Conversation

@kenahrens
Copy link
Copy Markdown
Member

Summary

  • issue: Set Speedscale overlay sidecar injection to true
  • automated run id: run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true
  • suspected fix: Update all banking-app Speedscale overlay annotation patches to inject=true.

Discovery Evidence

Cluster rollout attempts showed deployment annotations are reconciled to false by Argo due to overlay defaults in source control.

Speedscale Capture

  • dataset:
  • download command:
    Sidecar never appears in banking-app pods while overlay annotation remains false.

Reproduction

  1. Inspect kubernetes/overlays/speedscale/*-annotations.yaml
  2. Confirm sidecar.speedscale.com/inject is set to "false"
  3. Sync overlay via Argo and inspect deployment annotations
  • observed: Deployments reconcile back to inject=false and pods launch without sidecar.
  • expected: Deployment annotations stay at inject=true after sync and new pods include speedscale-goproxy.

Replay Validation

  • command:
  • result: pass

Artifacts

  • run artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/run.json
  • evidence artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/evidence.json
  • triage artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/triage.json
  • patch artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/patch.diff
  • validation artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/validation.log
  • result artifact: artifacts/run-microsvc-speedscale-overlay-microsvc-overlay-sidecar-inject-true/result.json

@kenahrens
Copy link
Copy Markdown
Member Author

Superseded by clean PR #68 (same overlay fix without unrelated prior branch commits).

@kenahrens kenahrens closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant