fix: resolve executor timeout due to lock contention in poll_work#13
Merged
Conversation
phillipleblanc
force-pushed
the
phillip/250127-fix-deadlock
branch
from
89cf761 to
3b46cb9
Compare
phillipleblanc
commented
Jan 26, 2026
phillipleblanc
force-pushed
the
phillip/250127-fix-deadlock
branch
2 times, most recently
from
d5f1983 to
c45c17b
Compare
peasee
approved these changes
Jan 26, 2026
…nt loop The metrics instrumentation PR introduced a hot-path call to total_pending_tasks() after every scheduler event. This method acquires read locks on all execution graphs, which combined with concurrent poll_work calls (acquiring write locks), caused deadlock-like behavior due to tokio RwLock fairness semantics. Changes: - Remove total_pending_tasks() from event loop hot path - Add periodic background task (5s interval) for pending_tasks metric - Add 100ms timeout to lock acquisition in total_pending_tasks() as safety net - Clean up unused imports
phillipleblanc
force-pushed
the
phillip/250127-fix-deadlock
branch
from
c45c17b to
0c567ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metrics instrumentation PR introduced a hot-path call to total_pending_tasks() after every scheduler event. This method acquires read locks on all execution graphs, which combined with concurrent poll_work calls (acquiring write locks), caused deadlock-like behavior due to tokio RwLock fairness semantics.
Changes: