fix: Correct Redshift pg_port default and add missing sslmode values#1671
Merged
Conversation
The Redshift docs incorrectly claimed pg_port defaults to 5439. The Postgres connector code has no .default() call on the port parameter, so the underlying tokio-postgres default of 5432 applies. Port 5439 is Redshift's standard port but not a Spice-level default. Updated the description across all doc versions to clarify that users should set this value explicitly. Also added the missing `disable` and `allow` values to the pg_sslmode parameter description in the vNext docs, matching the code's one_of constraint.
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://a7c1f64c.spiceai-org-website.pages.dev |
lukekim
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_portdescription corrected across all doc versions (vNext + 1.6.x through 1.11.x): The docs previously statedpg_portdefaults to5439. The Postgres connector code (connector-postgres/src/lib.rs) has no.default()call on the port parameter — the underlyingtokio-postgresdefault is5432, not5439. Port5439is Redshift's standard port but is not a Spice-level default. Updated the description to: "The PostgreSQL TCP port. Redshift uses port5439by default — set this explicitly."pg_sslmodevalues completed in vNext docs: The vNext parameter table listed onlyprefer,require,verify-ca,verify-full. The code'sone_ofconstraint also includesdisableandallow. Added these two missing values. Older versioned docs use a vaguer description (e.g., prefer) and were left as-is.Test plan
(default: 5439)text in any Redshift connector doc parameter tablepg_sslmoderow lists all six modes:disable,allow,prefer,require,verify-ca,verify-fullpg_port: 5439(correct — examples demonstrate the recommended explicit value)