feat(snippets): remove global navbar navlinks limit#770
Closed
Regrify wants to merge 9 commits intospicetify:mainfrom
Closed
feat(snippets): remove global navbar navlinks limit#770Regrify wants to merge 9 commits intospicetify:mainfrom
Regrify wants to merge 9 commits intospicetify:mainfrom
Conversation
Contributor
Regrify
commented
May 31, 2024
Regrify
commented
- removed the global nav bar item limit, so you don't have to scroll through the items
- removed the forced margin inside the marketplace for certain themes with the global nav bar enabled
Removed my own redundant css
added comma
Regrify
changed the title
rxri
reviewed
Jan 25, 2025
resources/snippets.json
Outdated
| "preview": "resources/assets/snippets/glob-nav-max-items.png" | ||
| }, | ||
| { | ||
| "title": "[Global Nav Bar] marketplace header margin fix", |
Member
There was a problem hiding this comment.
huh. this margin exists so the buttons are clickable. if you unset it, they won't be clickable again
Contributor
Author
There was a problem hiding this comment.
I have had certain themes make the menu overlap. though I have not disabled this in a long time so I'm not sure if that is still the case.
Removed the [Global Nav Bar] marketplace header margin fix snippet as it doesn't improve anything
rxri
changed the title
rxri
requested changes
Jan 25, 2025
Member
rxri
left a comment
rxri
left a comment
There was a problem hiding this comment.
remove the image glob-nav-mrktplc-margin.png
kyrie25
requested changes
Jan 27, 2025
| }, | ||
| { | ||
| "title": "[Global Nav Bar] remove scrolling overflow", | ||
| "description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not as much that it will overflow with the searchbar", |
Member
There was a problem hiding this comment.
Some wording suggestions because it sounds really confusing at first glance.
Suggested change
| "description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not as much that it will overflow with the searchbar", | |
| "description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not so much that it will interfere with the search bar.", |
Member
|
Unresolved review. Closing for inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.