Skip to content

feat(snippets): remove global navbar navlinks limit #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(snippets): remove global navbar navlinks limit #770

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ede2302
Update snippets.json
Plueres May 30, 2024
e725bd6
Update snippets.json
Plueres May 31, 2024
ce0f3fc
Update snippets.json
Plueres May 31, 2024
0a84736
Add files via upload
Plueres May 31, 2024
4d3a126
Update snippets.json
Plueres May 31, 2024
db54bb2
Merge branch 'main' into Fix-updated-snippets
Plueres Jan 25, 2025
4229fdd
Update snippets.json
Plueres Jan 25, 2025
b67605b
Merge branch 'spicetify:main' into Fix-updated-snippets
Plueres Jan 26, 2025
9b55968
Delete resources/assets/snippets/glob-nav-mrktplc-margin.png
Plueres Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added resources/assets/snippets/glob-nav-max-items.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added resources/assets/snippets/glob-nav-mrktplc-margin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions resources/snippets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,5 +376,17 @@
"description": "Changes the background of unplayable tracks to make it easier to spot them in large playlists.",
"code": ".main-trackList-disabled{background:#f004}.main-trackList-disabled:focus-within,.main-trackList-disabled:hover{background:#f005}.main-trackList-disabled.main-trackList-selected,.main-trackList-disabled.main-trackList-selected:hover{background:#f006}",
"preview": "resources/assets/snippets/More-Visible-Unplayable-Tracks"
},
{
"title": "[Global Nav Bar] remove scrolling overflow",
"description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not as much that it will overflow with the searchbar",
Copy link
Member

@kyrie25 kyrie25 Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording suggestions because it sounds really confusing at first glance.

Suggested change
"description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not as much that it will overflow with the searchbar",
"description": "Removes the max visible width restrictions of the 'sidebar' items. Useful if you have more than the scrolling limit but not so much that it will interfere with the search bar.",

"code": ".custom-navlinks-scrollable_container{max-width: unset!important}",
"preview": "resources/assets/snippets/glob-nav-max-items.png"
},
{
"title": "[Global Nav Bar] marketplace header margin fix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh. this margin exists so the buttons are clickable. if you unset it, they won't be clickable again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had certain themes make the menu overlap. though I have not disabled this in a long time so I'm not sure if that is still the case.

"description": "Global Nav Bar breaks the margin for certain themes, this removes the standard margin, and sets it back to 0",
"code": "div.marketplace-header:has(.marketplace-header__left .marketplace-sortBox-header){margin-top:unset;}",
"preview": "resources/assets/snippets/glob-nav-mrktplc-margin.png"
}
]
Loading