feat: Makes TPM device path configurable per Agent#25
Open
jsnctl wants to merge 1 commit intospiffe:masterfrom
Open
feat: Makes TPM device path configurable per Agent#25jsnctl wants to merge 1 commit intospiffe:masterfrom
jsnctl wants to merge 1 commit intospiffe:masterfrom
Conversation
* [WIP] Passing a user-defined TPM location * feat: Adds support for configurable tpm_path on Agent * Fall back to original OpenConfig when path is not provided * [From review] Remove redundant methods, add error Signed-off-by: Jason Costello <jason@cofide.io> --------- Signed-off-by: Jason Costello <jason@cofide.io>
jsnctl
changed the title
Collaborator
|
Sorry for not seeing this sooner. I am not getting notifications for some reason. Will try and fix. Seems like maybe the socket bits might not work on windows? I've recently tested the mainline plugin on windows and it seems to work. Would this work too, or would the socket code need to be split out to socket_unix/_windows verions? |
Author
|
Thanks @kfox1111, I'll have a look at fixing for Windows. It's also struck me this won't work when a chardev is required (ie with a real TPM) - so I'll need to add some handling for this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces
TPMPathas a configurable parameter for the Agent plugin to set a non-standard device location for the TPM. If the path is not provided, it falls back to the default caseThis is useful for using software TPMs (like
swtpm) which often mount in alternative chardev locations to the standard/dev/tpmrm0, and can be used to avoid clashes between hardware and software TPMS in scenarios like testing and CI