Abhishek/seed fail test java #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 9, 2025 23:32
- Updated package imports from oteltef to otelstef after main branch merge - Verified seed-based regression testing implementation matches PR #263 - All tests pass successfully - 3 Java-specific seeds loaded and tested correctly
Benchmark ResultBenchmark diff with base branchBenchmark result |
| class ReadWriteTest { | ||
| @Test | ||
| public void testCopy() throws IOException { | ||
| private boolean testCopySeed(long seed) throws IOException { |
Collaborator
There was a problem hiding this comment.
Where is the seed used in this test? I can't find any usage?
I don't think we need it here. We want seed saving and load tests generated via writerTest.java.tmpl. This should be equivalent of what we do for Go in this PR: https://github.com/splunk/stef/pull/263/files#diff-6cea806d1350c5a7621b9e3b780184637490a125dbc98f0296224c0fdf2e7eeb
Once writerTest.java.tmpl is modified, you can run make all in various directories (e.g. in go/otel and stef) to generate Java code and then run ./gradlew test to see how the tests work.
When you are happy with writerTest.java.tmpl, running make all in root directory will help confirm everything works correctly.
Collaborator
|
Nit: please use more descriptive commit message, PR title and description. Feel free to borrow from #263 which does similar things for Go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.