-
Notifications
You must be signed in to change notification settings - Fork 4
Abhishek/seed fail test java #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+95
−33
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
de6f9f1
Add seed-based regression testing for Java implementation
7c34a84
Merge remote-tracking branch 'origin/main' into abhishek/seed-fail-te…
5c72554
Implement seed storing for Java schema tests
7ad136d
Implement seed storing for Java schema tests
6cf074c
Merge branch 'main' into abhishek/seed-fail-test-java
fe2de9b
Fix imports after merge and verify seed-based testing works
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| 1134697243567416 | ||
| 1663904464129333 | ||
| 1726451308442583 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the seed used in this test? I can't find any usage?
I don't think we need it here. We want seed saving and load tests generated via writerTest.java.tmpl. This should be equivalent of what we do for Go in this PR: https://github.com/splunk/stef/pull/263/files#diff-6cea806d1350c5a7621b9e3b780184637490a125dbc98f0296224c0fdf2e7eeb
Once writerTest.java.tmpl is modified, you can run
make allin various directories (e.g. ingo/otelandstef) to generate Java code and then run./gradlew testto see how the tests work.When you are happy with writerTest.java.tmpl, running
make allin root directory will help confirm everything works correctly.