Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
There was a problem hiding this comment.
Pull request overview
Updates multiple ARB localization files (Crowdin sync) to incorporate new UI strings (e.g., sleep timer, credits) and adjust several existing labels/descriptions across locales.
Changes:
- Normalize some locale identifiers in
@@localeto BCP-47 hyphen form (e.g.,zh-CN,zh-TW,es-ES). - Add new credit strings (UniTune/MusicBrainz/Squigly) and new “Sleep timer” strings across multiple locales.
- Update a handful of existing strings (e.g., QQ Music provider description) and add many new strings in
ko/es-ES.
Reviewed changes
Copilot reviewed 8 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/l10n/arb/app_zh_TW.arb | Locale identifier normalization + new credits/sleep-timer strings + QQ Music description tweak. |
| lib/l10n/arb/app_zh_CN.arb | Locale identifier normalization + new credits/sleep-timer strings + QQ Music description tweak. |
| lib/l10n/arb/app_nl.arb | Adds new credits/sleep-timer strings + QQ Music description tweak. |
| lib/l10n/arb/app_ko.arb | Adds many new Korean strings; also changes some existing lines (notably some regress to English). |
| lib/l10n/arb/app_it.arb | Adds new credits/sleep-timer strings + QQ Music description tweak. |
| lib/l10n/arb/app_hi.arb | Adds new credits/sleep-timer strings + QQ Music description tweak. |
| lib/l10n/arb/app_es_ES.arb | Locale identifier normalization + many new strings; a few updated lines regress to English; one key has placeholder mismatch. |
| lib/l10n/arb/app_ar.arb | Adds new credits/sleep-timer strings; one placeholder name mismatch introduced. |
Suppressed comments (1)
lib/l10n/arb/app_es_ES.arb:5770
- This Spanish (es-ES) subtitle is in English. Localize it to Spanish to avoid mixed-language UI.
"downloadNativeWorkerSubtitle": "Android background service for extension downloads",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| }, | ||
| "cueSplitSplitting": "Dividiendo hoja CUE... ({current}/{total})", | ||
| "cueSplitSplitting": "¿Dividir \"{album}\" en archivos FLAC individuales {count} ?\n\nLos archivos se guardarán en el mismo directorio.", |
| "description": "Description for Apple Music provider" | ||
| }, | ||
| "lyricsProviderQqMusicDesc": "QQ Music (buena para canciones chinas, a\ntravés de proxy)", | ||
| "lyricsProviderQqMusicDesc": "QQ Music (good for Chinese songs, direct API)", |
| } | ||
| }, | ||
| "extensionsInstallPartialSuccess": "تم تثبيت {installed} من أصل {attempted} إضافات", | ||
| "extensionsInstallPartialSuccess": "تم تثبيت {count} من أصل {attempted} إضافات", |
| "description": "Setting for legacy TLS/network handling" | ||
| }, | ||
| "downloadNetworkCompatibilityModeEnabled": "Uso de ajustes TLS heredados para redes antiguas", | ||
| "downloadNetworkCompatibilityModeEnabled": "Allowing legacy HTTP endpoints; TLS verification remains enabled", |
| "description": "Setting for legacy TLS/network handling" | ||
| }, | ||
| "downloadNetworkCompatibilityModeEnabled": "레거시 HTTP 엔드포인트 허용; TLS 검증은 계속 활성화됨", | ||
| "downloadNetworkCompatibilityModeEnabled": "Allowing legacy HTTP endpoints; TLS verification remains enabled", |
| "@editMetadataMusicBrainzFilled": { | ||
| "description": "Snackbar after MusicBrainz suggestions were applied to the tag editor fields" | ||
| }, | ||
| "editMetadataMusicBrainzNothing": "MusicBrainZ에서 발견되지 않음", |
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.