Skip to content

Maintenance: Remove shared LDADD #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Maintenance: Remove shared LDADD #2058

wants to merge 2 commits into from
+22 −30

Conversation

yadij
Copy link
Contributor

@yadij yadij commented May 3, 2025 •
edited by rousskov
Loading

Most built binaries have a distinct set of dependencies and already have
their own foo_LDADD variables. Add a few variables to cover the
remaining binaries and stop setting an (incomplete) LDADD global.

Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay
binaries are built unconditionally.

yadij and others added 2 commits May 4, 2025 01:09
@yadij
Remove last uses of global LDADD
77899ab 
Binaries in Squid each have a distinct set of dependencies and thus
their own foo_LDADD variables. Stop setting an (incomplete) LDADD
for shared use in Makefile.am.
@yadij
Merge branch 'master' into rm-LDADD
d924d49
rousskov
rousskov approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adjusted PR description a little to be in sync with PR changes that set (the same) foo_LDADD dependencies for a few binaries (e.g., syntheticoperators and VirtualDeleteOperator). The original description implied that such binaries did not exist; they do exist, but they are an exception that does not justify LDADD global existence.

I also tried to disclose and explain a seemingly out-of-scope change -- EXTRA_PROGRAMS removal.

I am not clearing this PR for merging to give @yadij a chance to validate my description adjustments.

@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label May 6, 2025
squid-anubis pushed a commit that referenced this pull request May 6, 2025
@yadij @squid-anubis
Maintenance: Remove shared LDADD (#2058)
b9a4be5 
Most built binaries have a distinct set of dependencies and already have
their own foo_LDADD variables. Add a few variables to cover the
remaining binaries and stop setting an (incomplete) LDADD global.

Also removed unnecessary EXTRA_PROGRAMS because mem_node_test and splay
binaries are built unconditionally.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels May 6, 2025
@rousskov
Copy link
Contributor

rousskov commented May 6, 2025

squid-anubis added M-failed-staging-checks

Config file: openbsd-7.7.conf
  quirks-7.103 signed on 2025-05-06T14:17:42Z
  Can't find automake-1.16.5
  Couldn't install automake-1.16.5

@kinkie, can you help address the above OpenBSD test failure? AFAICT, Anubis will not merge PRs until that problem is gone.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-author author action is expected (and usually required) labels May 6, 2025
@kinkie kinkie mentioned this pull request May 6, 2025
Open
@kinkie
Copy link
Contributor

kinkie commented May 6, 2025

squid-anubis added M-failed-staging-checks

Config file: openbsd-7.7.conf
  quirks-7.103 signed on 2025-05-06T14:17:42Z
  Can't find automake-1.16.5
  Couldn't install automake-1.16.5

@kinkie, can you help address the above OpenBSD test failure? AFAICT, Anubis will not merge PRs until that problem is gone.

PR #2059 should fix it

@rousskov rousskov added the S-waiting-for-PR Closure of other PR(s), current or future, is expected (and usually required) label May 6, 2025
@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels S-waiting-for-PR Closure of other PR(s), current or future, is expected (and usually required)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yadij @rousskov @kinkie @squid-anubis