CI: Adopt OpenBSD v7.7 and pin it

[kinkie]

Pin the version of OpenBSD we use for our "slow" checks
and update the version of automake distributed with it.

[kinkie]

This should fix the problems of the broken job blocking the merge of PR #2058

[kinkie]

FreeBSD doesn't suffer the same problem, as we're pinning two releases there

[Copilot]

Pull Request Overview

This PR pins the OpenBSD version used in the CI for "slow" checks and updates the automake version distributed with it.

• Pin OpenBSD release to 7.7
• Update automake from 1.16.5 to 1.17

Comments suppressed due to low confidence (1)

.github/workflows/slow.yaml:205

• Ensure that the update to automake-1.17 is validated against all build steps, and update any related configuration or documentation if required to address potential behavioral differences.

automake-1.17

[rousskov]

Thank you! I adjusted PR title/description a bit to improve consistency/grammar.

[yadij]

Do the other branches need this backported as well now?

[rousskov]

@kinkie, OpenBSD test still fails. I could not tell why without studying openbsd-vm/v1/run.sh.

[kinkie]

I'll check and iterate later today.
All branches will need this

[yadij]

  ./test-builds.sh
  
  exec ssh: cd $GITHUB_WORKSPACE;
  export MAKE=gmake
  export pjobs="-j`gnproc`"
  export AUTOMAKE_VERSION=1.16
  export amver=${AUTOMAKE_VERSION}

... this (hard coded in slow.yaml) AUTOMAKE_VERSION=1.16 causes:

  ./test-builds.sh
  /usr/bin/bash /home/runner/work/_actions/vmactions/openbsd-vm/v1/run.sh execSSHSH
  Config file: openbsd-7.7.conf
  WARNING: Cannot find automake version 1.16
  Trying /usr/local/bin/automake[34]: /usr/local/bin/automake-1.16: not found
  WARNING: Cannot find libtool version 2.4.2
  Trying libtool (not (GNU libtool)) 1.5.26
  automake () : automake
  autoconf (2.72) : autoconf
  libtool  (1.5.26) : libtool
  libtool path : /usr/bin
  Bootstrapping primary Squid sources
  /usr/local/bin/aclocal[34]: /usr/local/bin/aclocal-1.16: not found
  Autotool bootstrapping failed. You will need to investigate and correct
  before you can develop on this source tree
  aclocal failed

[yadij]

Do we really have to explicitly set the autotools variables on top of installing the versioned package? Surely the right package being installed is enough.
If not, perhapse our bootstrap.sh can be improved to better detect the tool binaries.

[kinkie]

Doh! Sadly yes. Openbad is brain damaged in this regard. If we don't set them it will just complain and bail

[rousskov]

If comments are legal/OK here, please document the hidden dependency (missed in earlier PR commits). For example:

Suggested change

	automake-1.17 \
	automake-1.17 \ # keep in sync with AUTOMAKE_VERSION below

or perhaps

Suggested change

	automake-1.17 \
	automake-1.17 # keep in sync with AUTOMAKE_VERSION below \

I do not know which variant (if any) is correct in this context.

... and add a similar comment to AUTOMAKE_VERSION definition below.

Alternatively, we may be able to define OpenBSD Automake version once and use it in both places, but I do not have a recipe for that. Our CHECKOUT_FETCH_DEPTH recipe would not work well here because Automake version differs across jobs.

[kinkie]

Neither works, it's shell escaping.
And using a variable also doesn't work, the versions number might not align (e.g. 1.16.5 would correspond to 1.16).
I'll iterate on this solution, let's push it in as it is in order to unblock the other PRs.
Also, since we now pin the OS version, likelihood of this biting us is very reduced

[rousskov]

I'll iterate on this solution

Please do.

[rousskov]

I'll iterate on this solution

Please do.

[rousskov]

OpenBSD build still fails. @kinkie, please consider fully testing staging in your GitHub repository before (pushing and) requesting re-reviews here.