Recognize test.check macros and namespaces for cherry#803
Closed
willcohen wants to merge 1 commit intosquint-cljs:cljs-test-builtinfrom
Closed
Recognize test.check macros and namespaces for cherry#803willcohen wants to merge 1 commit intosquint-cljs:cljs-test-builtinfrom
willcohen wants to merge 1 commit intosquint-cljs:cljs-test-builtinfrom
Conversation
…tion - resolve-ns :cherry case maps the four clojure.test.check* namespaces to cherry-cljs/lib/clojure.test.check.js - builtin-refer-is-macro? refactored from a (ns-set × macro-name-set) check to a per-ns map keyed by namespace, so defspec/for-all can sit alongside the existing cljs.test entries. Behavior for cljs.test, clojure.test, cherry.test, squint.test unchanged. - No squint.internal additions and no squint runtime changes; the test.check macros themselves live in companion cherry change.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding squint change for squint-cljs/cherry#184, targeting
cljs-test-builtinbranch. Can retarget if/when that branch lands.This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.