The big Saltern refresh!

[rtasva]

Short description

Overhauls Saltern with a few big changes and additions brainstormed between Caws and myself

Why we need to add this

Map upkeep

Media (Video/Screenshots)

Checks

• I do not require assistance to complete the PR.
• Before posting/requesting review of a PR, I have verified that the changes work.
• I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
• I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

Changelog
🆑 Rose Tasva

• add: Saltern: Added Law Department.
• add: Saltern: Added Psychologist & Paramedic's offices.
• add: Saltern: New maints bar.
• tweak: Saltern: Reshuffled Service department layout.
• tweak: Saltern: Overhauled Cargo deptartment.
• tweak: Saltern: Moved around some maints rooms, made HOP maints not dead end.

[coderabbitai]

Warning

Review limit reached

@rtasva, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c7e18505-a124-4683-a710-38bc454a037b

📥 Commits

Reviewing files that changed from the base of the PR and between 017e399 and 7285a57.

📒 Files selected for processing (2)

• Resources/Maps/_Starlight/Stations/Saltern.yml
• Resources/Prototypes/_Starlight/Maps/saltern.yml

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Review failed

The head commit changed during the review from 9d4fd6b to 7285a57.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[CawsForConcern]

test fails are real, you have invalid devices in your map

CTRL+F in the map's .yml and search for the keyword invalid

    Failed GameMapsLoadableTest("StarlightSaltern") [7 s]
    Error Message:
     Multiple failures or warnings in test:
    1) SERVER: 1.313s [ERRO] entity_deserializer: Encountered invalid EntityUid reference while reading entity 6822, component: DeviceNetwork Exception: 
       at Robust.UnitTesting.Pool.TestPair`2.ReportErrorLogs() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 25
     at Robust.UnitTesting.Pool.TestPair`2.OnCleanDispose() in /home/runner/work/space-station-14/space-station-14/RobustToolbox/Robust.UnitTesting/Pool/TestPair.Recycle.cs:line 99

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 89f2a028-5d12-45d9-9e5a-b2069fa431ac

📥 Commits

Reviewing files that changed from the base of the PR and between c258657 and 54a711a.

📒 Files selected for processing (2)

• Resources/Maps/_Starlight/Stations/Saltern.yml
• Resources/Prototypes/_Starlight/Maps/saltern.yml

🚧 Files skipped from review as they are similar to previous changes (1)

• Resources/Prototypes/_Starlight/Maps/saltern.yml

---

📝 Walkthrough

Summary

This PR refreshes the Saltern station map for ongoing map upkeep. It adds Law, Psychologist, and Paramedic offices; adds a maintenance bar; reshapes the Service and Cargo departments; relocates maintenance rooms; and revises HOP maintenance access.

The Saltern configuration increases Bartender, Botanist, Lawyer, SecurityOfficer, and Musician staffing limits. It adds a Psychologist slot and RadioHost availability.

These changes affect station layout, department access, staffing availability, and player movement. Map connectivity and access changes may create dead ends or unintended access routes. The PR remains in progress.

Guideline gaps

• The PR does not explain the rationale for the staffing changes.
• The PR does not state whether Shared-first placement was considered.
• The PR does not state whether Starlight ownership comments are required for the map configuration.
• The PR does not identify required localization changes.
• The PR does not describe possible breaking gameplay changes.
• The PR does not explain the intended design impact of the revised departments and maintenance layout.

Walkthrough

The Saltern map configuration adds RadioHost and Psychologist positions and updates staffing limits for Bartender, Botanist, Lawyer, SecurityOfficer, and Musician.

Changes

Saltern configuration

Layer / File(s)	Summary
Job roster and staffing limits Resources/Prototypes/_Starlight/Maps/saltern.yml	The configuration adds RadioHost and Psychologist positions. It increases staffing limits for Bartender, Botanist, Lawyer, SecurityOfficer, and Musician.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Mergeability Score: ⚪ Minimal · up to 54a71

This PR updates Saltern’s map layout and related map definitions; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• ss14Starlight/space-station-14#5585: Adds RadioHost availability to another Starlight map prototype.
• ss14Starlight/space-station-14#5591: Adds RadioHost availability to Starlight map job declarations.
• ss14Starlight/space-station-14#5566: Adds RadioHost availability to another map job roster.

Suggested labels: T: Rework, T: New Content

Suggested reviewers: cawsforconcern

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: a substantial refresh of the Saltern station map.
Description check	✅ Passed	The description directly explains the Saltern map overhaul and lists the major department and maintenance changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[CawsForConcern]

review

changes are good overall, just a few things to address

air alarms

you have some air alarms that i think were removed during the shuffling, here's a few of them pointed out

some of these might be prior to your PR - it'd be nice for atmos if you wired up these areas with air alarms, still

psych could also do with an air alarm

maints bar inflatable wall

i think this might be a bit too easy to space arrivals due to the secret door here. it's one of those things that seems unlikely, but players are very good at making unlikely combinations happen

[rtasva]

still working on this, just been a busy week.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[CawsForConcern]

review 2

changes are good, spotted a few issues

missing APC for south solars

• airlocks, lightbulb unpowered here
• you need to link the airlocks to bolt each other as well

missing APC for west solars

• same issue as south solars, you need a APC and substation here

[CawsForConcern]

big approved

[github-actions]

Content + Integration Test Results

Tests 📝	Passed ✅	Failed ❌	Duration ⏱️
1681	1661	0	10m 56s

_{🎉 No failed tests in this run.}

Github Test Reporter by CTRF 💚