Adds a maintenance door variant for Journalism access - #5552
Conversation
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummaryAdds This supports Radio Host mapping and allows reporter doors to use Journalism access. The entity inherits the locked Journalism access configuration and uses the standard maintenance-door sprite. Changes
Risk areas
Guideline gaps
WalkthroughAdds ChangesJournalism maintenance airlock
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Resources/Prototypes/_Goobstation/Entities/Structures/Doors/Airlocks/access.yml`:
- Around line 20-27: Move the Starlight-only AirlockMaintJournalismLocked
prototype out of the Goobstation access.yml file into the corresponding
_Starlight access.yml. Define the parent airlock prototype there, then override
AirlockMaintJournalismLocked from _Starlight while preserving its existing
parent and maintenance sprite configuration; do not modify the Goobstation-owned
file.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 51da5df5-0895-4824-875a-84c6e68e68a4
📒 Files selected for processing (1)
Resources/Prototypes/_Goobstation/Entities/Structures/Doors/Airlocks/access.yml
|
@coderabbitai Review |
|
e22931e
Short description
Adds
AirlockMaintJournalismLocked, a maints door version ofAirlockJournalismLockedWhy we need to add this
Required for mapping!
This is a blocker for Radio Host getting mapped (and for Reporters getting their doors swapped to Journalism access, too!).
Media (Video/Screenshots)
fig. 1 - Maints door.
Checks