Skip to content

Adds a maintenance door variant for Journalism access - #5552

Merged
walksanatora merged 2 commits into
ss14Starlight:starlight-devfrom
CawsForConcern:Radio_Host
Aug 7, 2026
Merged

Adds a maintenance door variant for Journalism access#5552
walksanatora merged 2 commits into
ss14Starlight:starlight-devfrom
CawsForConcern:Radio_Host

Conversation

@CawsForConcern

Copy link
Copy Markdown
Contributor

Short description

Adds AirlockMaintJournalismLocked, a maints door version of AirlockJournalismLocked

Why we need to add this

Required for mapping!

This is a blocker for Radio Host getting mapped (and for Reporters getting their doors swapped to Journalism access, too!).

Media (Video/Screenshots)

image image

fig. 1 - Maints door.

Checks

  • I do not require assistance to complete the PR.
  • Before posting/requesting review of a PR, I have verified that the changes work.
  • I have added screenshots/videos of the changes, or this PR does not change in-game mechanics.
  • I affirm that my changes are licensed under the MIT License and grant permission for use in this repository under its conditions.

@CawsForConcern
CawsForConcern requested a review from a team August 7, 2026 09:13
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d17aad14-346b-4a4c-88be-3eb3033666fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Summary

Adds AirlockMaintJournalismLocked, a maintenance-door variant of AirlockJournalismLocked.

This supports Radio Host mapping and allows reporter doors to use Journalism access. The entity inherits the locked Journalism access configuration and uses the standard maintenance-door sprite.

Changes

  • Adds AirlockMaintJournalismLocked to the Starlight airlock access prototypes.
  • Updates Resources/Prototypes/_Starlight/Entities/Structures/Doors/Airlocks/access.yml.

Risk areas

  • The new prototype may have incorrect access or sprite behavior if its inheritance does not match the intended reporter-door configuration.
  • Existing maps must reference the new entity to produce a gameplay-visible effect.

Guideline gaps

  • The PR does not state whether the prototype belongs in Starlight rather than a Shared location.
  • The PR does not include a Starlight ownership comment.
  • The PR does not mention localization impact.
  • The PR does not describe breaking-change or design-impact considerations.

Walkthrough

Adds AirlockMaintJournalismLocked, inheriting locked journalism airlock access behavior and using the standard maintenance-door sprite.

Changes

Journalism maintenance airlock

Layer / File(s) Summary
Airlock prototype definition
Resources/Prototypes/_Starlight/Entities/Structures/Doors/Airlocks/access.yml
Adds AirlockMaintJournalismLocked with inherited locked journalism access behavior and the standard maintenance-door sprite.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: redmushie

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the added Journalism maintenance door variant.
Description check ✅ Passed The description explains the new entity and its mapping purpose, and it matches the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CawsForConcern CawsForConcern added Changes: No C# S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. T: Fix Changes: Prototypes labels Aug 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@Resources/Prototypes/_Goobstation/Entities/Structures/Doors/Airlocks/access.yml`:
- Around line 20-27: Move the Starlight-only AirlockMaintJournalismLocked
prototype out of the Goobstation access.yml file into the corresponding
_Starlight access.yml. Define the parent airlock prototype there, then override
AirlockMaintJournalismLocked from _Starlight while preserving its existing
parent and maintenance sprite configuration; do not modify the Goobstation-owned
file.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 51da5df5-0895-4824-875a-84c6e68e68a4

📥 Commits

Reviewing files that changed from the base of the PR and between b5d4edd and 6fc755b.

📒 Files selected for processing (1)
  • Resources/Prototypes/_Goobstation/Entities/Structures/Doors/Airlocks/access.yml

Comment thread Resources/Prototypes/_Goobstation/Entities/Structures/Doors/Airlocks/access.yml Outdated
@github-actions github-actions Bot added size/XS S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 7, 2026
@CawsForConcern CawsForConcern removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Aug 7, 2026
@Forrestgod718

Copy link
Copy Markdown
Contributor

@coderabbitai Review

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@starlightgithub starlightgithub Bot added S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 7, 2026
@redmushie
redmushie added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 7, 2026
@walksanatora
walksanatora added this pull request to the merge queue Aug 7, 2026
Merged via the queue into ss14Starlight:starlight-dev with commit e22931e Aug 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: No C# Changes: Prototypes S: Approved Status: Reviewed and approved by at least one maintainer or dev; a PR may require another approval. size/XS T: Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants