NeoAvali: Female displacement fixes pt. 2 - #5558
Conversation
📝 WalkthroughSummaryThis PR fixes additional female ProtoAvali sprite displacements. It primarily corrects shoes and clothing placements, including armor, backpacks, masks, head items, hands, and gloves. The inventory definition moves to
User impactFemale ProtoAvali equipment should align correctly during gameplay. The shared inventory configuration reduces duplication between the affected prototypes. Risk areas
Guideline gaps
WalkthroughThe changes add a reusable ChangesNeo Avali inventory configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/_Starlight/Entities/Mobs/Species/Protogen/avali.yml`:
- Line 114: Update the parent ordering for the Protogen Avali prototype so
BaseInventoryProtoAvali appears before BaseSpeciesDummy, while preserving
BaseProtogenAppearance and the existing parent set.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 412021db-fa6d-4ce6-928c-bd5ec13c7c07
📒 Files selected for processing (2)
Resources/Prototypes/_Starlight/Entities/Mobs/Species/Protogen/avali.ymlResources/Prototypes/_Starlight/Inventory/inventories.yml
|
@coderabbitai review |
|
|
@coderabbitai please review again. |
|
✅ Action performedFull review finished. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…light-14 into ProtoAvaliDisplacementsFix2
…hetti-bit/starlight-14 into ProtoAvaliDisplacementsFix2
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Fixed merge conflicts. |
Content + Integration Test ResultsSummary:
Failed Tests:
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
...What? |
e073c35
Short description
Fixes some missed displacements, mainly the shoes and other clothing, the only thing that was fixed by #5515 was the uniform.
Moves the inventory definition to
Resources\Prototypes\_Starlight\Inventory\inventories.ymland assigns it the ID ofBaseInventoryNeoAvali.BaseInventoryNeoAvaliis a child ofBaseInventoryAvali.id: BaseMobNeoAvalinow is a child ofBaseInventoryNeoAvali. Easier to manage.Why we need to add this
Cursed four legged avali bad.
Media (Video/Screenshots)
Before
After
Renala our guinea pig (again):
Random outfit:
Checks
Changelog
🆑 Spaghetti-Bit