Fix K9 identity concealment issue - #5954
Merged
walksanatora merged 1 commit intoSep 3, 2026
Merged
Conversation
github-actions
Bot
added
S: Untriaged
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 SummarySummaryAdds
This is an interim solution until collar-based identification is implemented. Gameplay and user impact
Notable changes
Risk areas
Guideline gapsGuideline gaps: None identified from the available PR context. WalkthroughThe identity system now supports a reusable ChangesIdentity visibility
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to K9s will remain identifiable even when concealment equipment would otherwise hide their identity, while existing Borg behavior is preserved. The change is mergeable with explicit owner awareness that future uses of the reusable marker must be restricted to trusted entity-assignment paths to avoid unintended identity disclosure. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Content + Integration Test ResultsFailed Tests
Github Test Reporter by CTRF 💚 |
walksanatora
approved these changes
Sep 3, 2026
starlightgithub
Bot
added
S: Approved
Merged
via the queue into
ss14Starlight:starlight-dev
with commit Sep 3, 2026
a05b0b5
22 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Adds an AlwaysIdentifiableComponent to the IdentitySystem to ignore the IdentitySystem's concealment code.
Why we need to add this
I added #5816 to allow smart corgis and animals to begin to leverage the identity system.
K9s do NOT have an ID slot and as such immediately fail to identify with their sec mask on.
With this change, K9s will be always identifiable.
This isn't a permanent solution to the matter; there is an in-flight bit of dev work going on in the 'Security K9' channel in #pr-workshop that is working to add collars in lieu of the existing system for K9s (tracking implanter and bespoke job identification code). Collars will act as PDAs with suit coordinates.
Until that's done, this will help maintain gameplay-as-intended. The component is also decent for other situations that might spring up where something may need to be always identifiable.
Media (Video/Screenshots)
Fixes this:
Checks
Changelog
🆑 Sparlight