Use vendor/composer/installed.php in TodoByPackageVersionRule.php

[ruudk]

Fixes #146

[ruudk]

@staabm I think the failing test, is actually a wrong test. How could that ever have worked? Given that composer.json requires phpunit ^9 || ^10.5. So the TODO: phpunit/phpunit:<10 error can only happen on older PHP versions where it's even allowed.

[staabm]

Given that composer.json requires phpunit ^9 || ^10.5. So the TODO: phpunit/phpunit:<10 error can only happen on older PHP versions where it's even allowed.

is it related to the same thing you are fixing here? phpstan-src itself used PHPunit 9.x for a long time and only recently updated to 11.x.

maybe the test worked because of the phpunit version in phpstan-src, as it seems it did not use the projects composer.json, as you said?

[ruudk]

Yes I believe that is the case. Shall I fix the test?

[staabm]

yes please do

[ruudk]

@staabm Done

[ruudk]

It's having issues with my fork, somehow. Not sure how I can resolve this.

[staabm]

just realized after merge: next time don't delete such line but make it empty. that way you don't need unrelated changes in test expectations

[ruudk]

Ah that's clever

[staabm]

thank you!