Skip to content

Port towards jrl-v2#2923

Open
j-matheron wants to merge 6 commits into
stack-of-tasks:develfrom
j-matheron:topic/jrl-next
Open

Port towards jrl-v2#2923
j-matheron wants to merge 6 commits into
stack-of-tasks:develfrom
j-matheron:topic/jrl-next

Conversation

@j-matheron

@j-matheron j-matheron commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Port pinocchio towards jrl-v2

Checklist

  • I have run pre-commit run --all-files or pixi run lint
  • I have performed a self-review of my own code
  • I have commented my code where necessary
  • I have made corresponding changes to the doxygen documentation
  • I have added tests that prove my fix or feature works
  • I have updated the CHANGELOG or added the "no changelog" label if it's a CI-related issue
  • I have updated the README credits section

TODO

  • Update release process
    • Edit development/release.md to use jrl-release.py
    • Edit release environment to ease the process
  • Add a cmake/get-example-robot-data.cmake script to be able to fetch content example-robot-data (back compatibility)

Comment thread pixi.toml
ccache = ">=4.9.1"
cxx-compiler = ">=1.7.0"
cmake = ">=3.10"
jrl-cmakemodules = ">=2.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also put it in package.build-dependencies.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread pixi.toml
cxx-compiler = ">=1.7.0"
cmake = ">=3.10"
jrl-cmakemodules = ">=2.0.0"
example-robot-data = ">=5.0.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also put it in package.build-dependencies

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

Comment thread CMakeLists.txt
Comment on lines +87 to +88
# TODO why not neccessary in Simple
set(Boost_USE_DEBUG_RUNTIME OFF)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should investigate this issue before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants