Fix logging configuration to prevent OpenTelemetry handler conflicts #8269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logging configuration to prevent OpenTelemetry handler conflicts
This PR modifies how DSPy configures its loggers to prevent conflicts with OpenTelemetry logging handlers and avoid long blocking operations during logger configuration.
Problem
The current implementation uses
logging.config.dictConfig()
which triggers a full handler cleanup through_clearExistingHandlers()
. This causes issues when OpenTelemetry logging handlers are present in the environment because:Here's an example that demonstrates the issue run with
opentelemetry-instrument
:This simple code takes 30+ seconds to run and often needs to be interrupted. Here's the stack trace showing where it blocks:
Solution
This PR replaces
dictConfig
with direct logger configuration using Python's logging API. The new implementation:Key changes:
logging.StreamHandler
andlogging.Formatter
directlyThis approach allows DSPy to:
Testing
The modified code runs instantly without delays, even in environments with OpenTelemetry handlers present. The logging output remains unchanged, maintaining backward compatibility while fixing the performance issue.