Skip to content

Fix logging configuration to prevent OpenTelemetry handler conflicts #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −26
Open

Fix logging configuration to prevent OpenTelemetry handler conflicts #8269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 17 additions & 26 deletions dspy/utils/logging_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,29 +55,20 @@ def enable_logging():


def configure_dspy_loggers(root_module_name):
logging.config.dictConfig(
{
"version": 1,
"disable_existing_loggers": False,
"formatters": {
"dspy_formatter": {
"format": LOGGING_LINE_FORMAT,
"datefmt": LOGGING_DATETIME_FORMAT,
},
},
"handlers": {
"dspy_handler": {
"formatter": "dspy_formatter",
"class": "logging.StreamHandler",
"stream": DSPY_LOGGING_STREAM,
},
},
"loggers": {
root_module_name: {
"handlers": ["dspy_handler"],
"level": "INFO",
"propagate": False,
},
},
}
)
formatter = logging.Formatter(fmt=LOGGING_LINE_FORMAT, datefmt=LOGGING_DATETIME_FORMAT)

handler = logging.StreamHandler(stream=DSPY_LOGGING_STREAM)
handler.setFormatter(formatter)
handler.set_name("dspy_handler")

logger = logging.getLogger(root_module_name)
logger.setLevel(logging.INFO)
logger.propagate = False

for existing_handler in logger.handlers[:]:
if getattr(existing_handler, "name", None) == "dspy_handler":
Comment on lines +62 to +69
Copy link
Preview

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The handler name string "dspy_handler" is duplicated in multiple places; consider defining it as a constant to avoid typos and simplify updates.

Suggested change
handler.set_name("dspy_handler")
logger = logging.getLogger(root_module_name)
logger.setLevel(logging.INFO)
logger.propagate = False
for existing_handler in logger.handlers[:]:
if getattr(existing_handler, "name", None) == "dspy_handler":
handler.set_name(DSPY_HANDLER_NAME)
logger = logging.getLogger(root_module_name)
logger.setLevel(logging.INFO)
logger.propagate = False
for existing_handler in logger.handlers[:]:
if getattr(existing_handler, "name", None) == DSPY_HANDLER_NAME:

Copilot uses AI. Check for mistakes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it how it was before. if needed I can just create a constant

logger.removeHandler(existing_handler)

logger.addHandler(handler)

return logger