Skip to content

ci: expand test job matrix with ROOT 6 environment #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
plexoos wants to merge 1 commit into from
Closed

ci: expand test job matrix with ROOT 6 environment #619

plexoos wants to merge 1 commit into from

Conversation

@plexoos
Copy link
Member

@plexoos plexoos commented Nov 1, 2023

No description provided.

This was referenced Nov 2, 2023
Closed
Merged
plexoos added a commit to plexoos/star-sw that referenced this pull request Nov 3, 2023
@plexoos
fix: include missing header TLine.h
4fed0a4 
These errors appear when building the code against ROOT6.24

```
.sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:434:18: error: invalid use of incomplete type 'class TLine'
  434 |             lineB->Draw();
      |                  ^~
In file included from .sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:84:
/opt/software/linux-scientific7-x86_64/gcc-11.2.1/root-6.24.06-vianfhcgeujnnnnhm7g6hhr3tnsiwfqt/include/TPaveText.h:19:7: note: forward declaration of 'class TLine'
   19 | class TLine;
      |       ^~~~~
```

See star-bnl#619 for details
@plexoos plexoos mentioned this pull request Nov 3, 2023
Merged
@plexoos plexoos added the ROOT6 Issues and changes related to transition from ROOT5 to ROOT6 label Nov 3, 2023
plexoos added a commit that referenced this pull request Nov 7, 2023
@plexoos
fix: include missing header TLine.h (#626)
4046a0a 
These errors appear when building the code against ROOT6.24

```
.sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:434:18: error: invalid use of incomplete type 'class TLine'
  434 |             lineB->Draw();
      |                  ^~
In file included from .sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:84:
/opt/software/linux-scientific7-x86_64/gcc-11.2.1/root-6.24.06-vianfhcgeujnnnnhm7g6hhr3tnsiwfqt/include/TPaveText.h:19:7: note: forward declaration of 'class TLine'
   19 | class TLine;
      |       ^~~~~
```

See #619 for details
klendathu2k pushed a commit that referenced this pull request Nov 7, 2023
@plexoos
fix: redefine overloaded virtual methods in derived class (#625)
43def14 
Compiler errors due to hidden virtual method appear when building the
code against ROOT6.24

```
g++ -m64 -fPIC -pipe -Wall -Woverloaded-virtual -std=c++0x -Wno-long-long -pthread -Werror -O2 -g -falign-loops -falign-jumps -falign-functions -Dsl79_gcc485 -D__ROOT__ -DNEW_DAQ_READER -I. -IStRoot -I.sl79_gcc485/include -I/star/ROOT/6.24.06/geant3/TGeant3 -I/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include -c .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx -o .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.o
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:804:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t)' was hidden [-Werror=overloaded-virtual]
    virtual void ProcessEvent(Int_t eventId);
                 ^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error:   by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
   virtual void ProcessEvent();
                ^
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:882:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t, Bool_t)' was hidden [-Werror=overloaded-virtual]
    virtual void ProcessEvent(Int_t eventId, Bool_t isInterruptible);
                 ^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error:   by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
   virtual void ProcessEvent();
                ^
```

See #619 for details
@plexoos plexoos force-pushed the build_root624 branch 2 times, most recently from da78ff3 to caa6d6b Compare November 8, 2023 15:00
@plexoos plexoos mentioned this pull request Nov 8, 2023
Merged
@plexoos plexoos force-pushed the build_root624 branch 6 times, most recently from 969f8f8 to 03d5928 Compare November 17, 2023 14:47
@klendathu2k
Copy link
Contributor

klendathu2k commented Dec 1, 2023

I took a look at the Sti geometry test failures. I cannot reproduce the problem in the production environment. Is there a way for me to run the code in the same environment and against the same build as the failed tests?

@plexoos
Copy link
Member Author

plexoos commented Dec 1, 2023

of course #620 (comment)

@plexoos plexoos changed the title build: switch base image to ROOT 6.24 ci: expand job matrix with ROOT 6.24 environment Feb 1, 2024
dkapukchyan pushed a commit to dkapukchyan/star-sw that referenced this pull request Mar 11, 2024
@plexoos @dkapukchyan
fix: include missing header TLine.h (star-bnl#626)
9b350eb 
These errors appear when building the code against ROOT6.24

```
.sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:434:18: error: invalid use of incomplete type 'class TLine'
  434 |             lineB->Draw();
      |                  ^~
In file included from .sl79_gcc11/OBJ/StRoot/StFgtPool/StFgtQaMakers/StFgtPedStatQA.cxx:84:
/opt/software/linux-scientific7-x86_64/gcc-11.2.1/root-6.24.06-vianfhcgeujnnnnhm7g6hhr3tnsiwfqt/include/TPaveText.h:19:7: note: forward declaration of 'class TLine'
   19 | class TLine;
      |       ^~~~~
```

See star-bnl#619 for details
dkapukchyan pushed a commit to dkapukchyan/star-sw that referenced this pull request Mar 11, 2024
@plexoos @dkapukchyan
fix: redefine overloaded virtual methods in derived class (star-bnl#625)
2162d82 
Compiler errors due to hidden virtual method appear when building the
code against ROOT6.24

```
g++ -m64 -fPIC -pipe -Wall -Woverloaded-virtual -std=c++0x -Wno-long-long -pthread -Werror -O2 -g -falign-loops -falign-jumps -falign-functions -Dsl79_gcc485 -D__ROOT__ -DNEW_DAQ_READER -I. -IStRoot -I.sl79_gcc485/include -I/star/ROOT/6.24.06/geant3/TGeant3 -I/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include -c .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx -o .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.o
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:804:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t)' was hidden [-Werror=overloaded-virtual]
    virtual void ProcessEvent(Int_t eventId);
                 ^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error:   by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
   virtual void ProcessEvent();
                ^
In file included from .sl79_gcc485/include/StarVMCApplication.h:10:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:21,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-6.24.06-gbmdgvxscayjf6nqc5tatcs424pan4gs/include/TVirtualMC.h:882:17: error: 'virtual void TVirtualMC::ProcessEvent(Int_t, Bool_t)' was hidden [-Werror=overloaded-virtual]
    virtual void ProcessEvent(Int_t eventId, Bool_t isInterruptible);
                 ^
In file included from .sl79_gcc485/include/TGeant3TGeo.h:12:0,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.h:22,
                 from .sl79_gcc485/OBJ/StarVMC/StVMCMaker/StVMCMaker.cxx:98:
.sl79_gcc485/include/TGeant3.h:1061:16: error:   by 'virtual void TGeant3::ProcessEvent()' [-Werror=overloaded-virtual]
   virtual void ProcessEvent();
                ^
```

See star-bnl#619 for details
@plexoos plexoos changed the title ci: expand job matrix with ROOT 6.24 environment ci: expand job matrix with ROOT 6 environment Apr 17, 2024
@plexoos plexoos changed the title ci: expand job matrix with ROOT 6 environment ci: expand test job matrix with ROOT 6 environment Apr 17, 2024
@plexoos
Copy link
Member Author

plexoos commented Apr 19, 2024

duplicates #606

@plexoos plexoos closed this Apr 19, 2024
@plexoos plexoos deleted the build_root624 branch April 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl Awaiting requested review from veprbl veprbl will be requested when the pull request is marked ready for review veprbl is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

ROOT6 Issues and changes related to transition from ROOT5 to ROOT6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plexoos @klendathu2k