BFC options for FWD productions #759
Conversation
jdbrice
requested review from
R-Witt,
fisyak,
genevb,
iraklic,
klendathu2k and
plexoos
as code owners
| {"FttQA","","fttChain","","StFttQAMaker","StFttQAMaker", "sTGC Raw hit QA maker", kFALSE}, | ||
|
|
||
| {"FwdTrack","","","fcsDb","StFwdTrackMaker", | ||
| "XMLIO,genfit2,KiTrack,StarGeneratorUtil,libMathMore,StEventUtilities,StEpdUtil,StFwdTrackMaker", |
There was a problem hiding this comment.
[minor] [off topic]. Could you comment on why the tracker depends on event generator utilities?
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
Looks OK to me as well, but would also like to hear about the event generator dependence @klendathu2k asked.
| {"PicoVtxVpdOrDefault","","","-PicoVtxDefault" ,"","","pico Vtx cut on Tof and VPD or default",kFALSE}, | ||
| {"PicoVtxFXT" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx constraint on FXT [198,202] mode",kFALSE}, | ||
| {"PicoVtxMtd" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx using MTD matching mode",kFALSE}, | ||
| {"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD" ,kFALSE}, |
There was a problem hiding this comment.
| {"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD" ,kFALSE}, | |
| {"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD",kFALSE}, |
There was a problem hiding this comment.
Actually, don't we need a concurrent change in StBFChain.cxx to pass this along to StPicoDstMaker?
else if ( GetOption("PicoVtxless")) mk->SetAttr("PicoVtxMode", "PicoVtxless");
...near line 698 of StBFChain.cxx.
| {"PicoVtxVpdOrDefault","","","-PicoVtxDefault" ,"","","pico Vtx cut on Tof and VPD or default",kFALSE}, | ||
| {"PicoVtxFXT" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx constraint on FXT [198,202] mode",kFALSE}, | ||
| {"PicoVtxMtd" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx using MTD matching mode",kFALSE}, | ||
| {"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD" ,kFALSE}, |
There was a problem hiding this comment.
Actually, don't we need a concurrent change in StBFChain.cxx to pass this along to StPicoDstMaker?
else if ( GetOption("PicoVtxless")) mk->SetAttr("PicoVtxMode", "PicoVtxless");
...near line 698 of StBFChain.cxx.
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new BFC (BigFullChain) options to support Forward (FWD) detector productions, including fast simulation capabilities and track matching functionality.
- Adds
fttSimoption to enable FTT (Forward Tracking Telescope) fast simulation - Adds
FcsTrackMatchoption for matching forward tracks to FCS (Forward Calorimeter System) clusters - Adds
PicoVtxlessoption to disable vertex requirements for forward detector analysis
| {"fttSim","fttChain","","StEvent,fttDb", | ||
| "StFttFastSimulatorMaker","StFttFastSimulatorMaker","Ftt Fast Simulator", kFALSE}, |
There was a problem hiding this comment.
[nitpick] The description 'Ftt Fast Simulator' should use consistent capitalization with other entries. Consider 'FTT Fast Simulator' to match the naming convention used elsewhere in the file.
| {"FcsTrackMatch","","","FwdTrack","StFcsTrackMatchMaker", | ||
| "StFcsTrackMatchMaker", |
There was a problem hiding this comment.
[nitpick] The formatting is inconsistent with other entries. The second line should be aligned with the opening quote of the first line to maintain consistent indentation style throughout the file.
|
Is this pull request still actual? Or has it been split across other PRs? Either way, besides "co-pilot", are there any aspects that need follow-up before closing/merging? |
6 participants
PicoVtxless: sets the PicoDst vertex mode to "Vtxless" - to mirror update in codefttSim: Run the ftt (fast) simFcsTrackMatch: run the Fwd track to FCS cluster matching