Skip to content
Open
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions StRoot/StBFChain/BigFullChain.h
Original file line number Diff line number Diff line change
Expand Up @@ -1707,6 +1707,8 @@ Bfc_st BFC[] = { // standard chains
"StFcsPointMaker","StFcsPointMaker,libMinuit","Fill FCS points", kFALSE},
{"fcsPi0Libs","", "", "MuDst", "", "StFcsPi0FinderForEcal", "Libs for FCS Pi0 Finder", kFALSE},
// FTT
{"fttSim","fttChain","","StEvent,fttDb",
"StFttFastSimulatorMaker","StFttFastSimulatorMaker","Ftt Fast Simulator", kFALSE},
Comment on lines +1710 to +1711
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The description 'Ftt Fast Simulator' should use consistent capitalization with other entries. Consider 'FTT Fast Simulator' to match the naming convention used elsewhere in the file.

Copilot generated this review using guidance from repository custom instructions.
{"ftt","fttChain","","FttDat,FttHitCalib,FttClu,FttPoint", "StMaker","StChain","FST chain" ,kFALSE},
{"FttDat","","fttChain","StEvent","StFttRawHitMaker","StFttRawHitMaker,StEvent",
"sTGC Raw hit maker", kFALSE},
Expand All @@ -1721,6 +1723,9 @@ Bfc_st BFC[] = { // standard chains
{"FwdTrack","","","fcsDb","StFwdTrackMaker",
"XMLIO,genfit2,KiTrack,StarGeneratorUtil,libMathMore,StEventUtilities,StEpdUtil,StFwdTrackMaker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] [off topic]. Could you comment on why the tracker depends on event generator utilities?

"Forward Track Maker", kFALSE},
{"FcsTrackMatch","","","FwdTrack","StFcsTrackMatchMaker",
"StFcsTrackMatchMaker",
Comment on lines +1726 to +1727
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The formatting is inconsistent with other entries. The second line should be aligned with the opening quote of the first line to maintain consistent indentation style throughout the file.

Copilot generated this review using guidance from repository custom instructions.
"Forward Track to FCS Match Maker", kFALSE},

#if 0
{"fpd" ,"fpd","","", "StFpdMaker","StFpdMaker","FPD/BBC Data base chain",kFALSE},
Expand Down Expand Up @@ -1949,6 +1954,7 @@ Bfc_st BFC[] = { // standard chains
{"PicoVtxVpdOrDefault","","","-PicoVtxDefault" ,"","","pico Vtx cut on Tof and VPD or default",kFALSE},
{"PicoVtxFXT" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx constraint on FXT [198,202] mode",kFALSE},
{"PicoVtxMtd" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx using MTD matching mode",kFALSE},
{"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD" ,kFALSE},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD" ,kFALSE},
{"PicoVtxless" ,"","","-PicoVtxDefault" ,"" ,"","pico Vtx NOT required for FWD",kFALSE},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, don't we need a concurrent change in StBFChain.cxx to pass this along to StPicoDstMaker?

else if ( GetOption("PicoVtxless"))      mk->SetAttr("PicoVtxMode", "PicoVtxless");

...near line 698 of StBFChain.cxx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in #639

{"PicoCovMtxSkip" ,"","","" ,"" ,"","Do not write covariance matrices to picoDst (default)",kFALSE},
{"PicoCovMtxWrite","","","-PicoCovMtxSkip" ,"" ,"","Write track covariance matrices to picoDst",kFALSE},
{"PicoBEmcSmdSkip" ,"","","" ,"" ,"","Do not write BSMD to picoDst (default)",kFALSE},
Expand Down