starknet_transaction_prover: per-request structured log with request-id#14165
starknet_transaction_prover: per-request structured log with request-id#14165avi-starkware wants to merge 1 commit into
Conversation
PR SummaryMedium Risk Overview The shared Several root-level HTML design notes document middleware deduplication options and OHTTP request-id privacy tradeoffs (explanatory, not runtime behavior). Reviewed by Cursor Bugbot for commit fd81285. Bugbot is set up for automated code reviews on this repo. Configure here. |
948a1e9 to
88c5a6b
Compare
0ae3b31 to
2dcb716
Compare
88c5a6b to
0df4834
Compare
2dcb716 to
f83f30c
Compare
1f5f854 to
abc893a
Compare
f83f30c to
53b6a1e
Compare
53b6a1e to
4645e9b
Compare
abc893a to
170c535
Compare
170c535 to
889c170
Compare
4645e9b to
278ffaa
Compare
278ffaa to
6a64324
Compare
|
Artifacts upload workflows: |
b232a8e to
b74ee13
Compare
b74ee13 to
49a7855
Compare
49a7855 to
112d26d
Compare
112d26d to
fef476a
Compare
Adds `RequestLogLayer`, the outermost middleware that emits one `event="http_request"` log line per request (request_id, method, path, status, latency_ms) and echoes the id on the response. The id is accepted from `x-request-id` when it is a short printable-ASCII token, otherwise a UUID v4 is generated; hostile inputs are dropped to prevent header smuggling and log-field explosion. No request body bytes are inspected (transaction calldata is private user data). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fef476a to
fd81285
Compare
5e85929 to
f81df1e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fd81285. Configure here.
|
|
||
| </div> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Four HTML design documents accidentally committed to repo root
Medium Severity
Four HTML files (middleware_stack_alternatives.html, request_id_pr757_fix.html, request_id_scope.html, request_id_tradeoff.html) are committed to the repository root. These are richly-styled design analysis documents with embedded SVG diagrams that were clearly used as working notes during development. The repository has no other HTML files anywhere, and these reference internal PRs and architectural alternatives — they're development artifacts, not production code.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit fd81285. Configure here.



Adds
RequestLogLayerthat emits oneevent="http_request"log line perrequest with request_id, method, path, status, and latency_ms. The id is
accepted from
x-request-idor generated as a 128-bit random hex string,and is echoed back on the response so callers can quote it. No request
body bytes are inspected (transaction calldata is private user data).
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com